samples: matter: Moved watchdog enabling into snippet #18783
+193
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a dedicated snippet that allows to enable watchdog in the Matter applications. Additionally, watchdog was by default disabled in all dts files to fix the bug that we observe in CI and it leads into unexpected application reboots. Signed-off-by: Kamil Kasperczyk <[email protected]>
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2b69aebec1599caff197f0e1aa4066589ff05c95 more detailssdk-nrf:
Github labels
List of changed files detected by CI (67)Outputs:ToolchainVersion: b81a7cd864 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
nordicjm
reviewed
Nov 11, 2024
| @@ -0,0 +1,8 @@ | |||
| /* Copyright (c) 2024 Nordic Semiconductor ASA | |||
There was a problem hiding this comment.
don't see what this snippet has to do with matter (in the name, that is)
Comment on lines
+6
to
+21
| nrf52840dk/nrf52840: | ||
| append: | ||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf52840dk_nrf52840.overlay | ||
| nrf5340dk/nrf5340/cpuapp: | ||
| append: | ||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf5340dk_nrf5340_cpuapp.overlay | ||
| nrf7002dk/nrf5340/cpuapp: | ||
| append: | ||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf7002dk_nrf5340_cpuapp.overlay | ||
| thingy53/nrf5340/cpuapp: | ||
| append: | ||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf5340dk_nrf5340_cpuapp.overlay | ||
| nrf54l15dk/nrf54l15/cpuapp: | ||
| append: | ||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf54l15dk_nrf54l15_cpuapp.overlay | ||
| nrf54h20dk/nrf54h20/cpuapp: |
There was a problem hiding this comment.
assume these can all be wildcard for any boards with these socs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a dedicated snippet that allows to enable watchdog in the Matter applications. Additionally, watchdog was by default disabled in all dts files to fix the bug that we observe in CI and it leads into unexpected application reboots.
WIP: docs still needed