Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: wifi: radio_test: Fix crash during temp and rssi get #18896

Merged
merged 1 commit into from
Nov 14, 2024

Commits on Nov 14, 2024

  1. samples: wifi: radio_test: Fix crash during temp and rssi get

    Get temperature and RSSI commands don't take any args, but due to
    copy-paste, the code tries to parse the args, argv[1] without any NULL
    or boundary checks causing a crash.
    
    This bug is quite old but in nRF53 (and 52) the address 0x0 is a valid
    address (IIRC mapped to begining of external flash), so, the conversion
    to string passes, though it returns garbage but the check for the
    returned value is completely unnecessary, so it doesn't matter if that
    is invoked or not, because of this, the issue was hidden.
    
    In nRF54H the address 0x0 is not mapped and is considered invalid and
    leading to the crash.
    
    Signed-off-by: Chaitanya Tata <[email protected]>
    krish2718 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8039b91 View commit details
    Browse the repository at this point in the history