nrf_modem: v2.5.0 release #1079

eivindj-nordic · 2023-09-25T12:10:14Z

See CHANGELOG file for details.

anhmolt · 2023-09-26T10:55:39Z

nrf_modem/CMakeLists.txt

+  nrfxlib_calculate_lib_path(NRF_MODEM_LIB_DIR SOC_MODE BASE_DIR ${CMAKE_CURRENT_SOURCE_DIR}
    SOFT_FLOAT_FALLBACK
  )


Suggested change

nrfxlib_calculate_lib_path(NRF_MODEM_LIB_DIR SOC_MODE BASE_DIR ${CMAKE_CURRENT_SOURCE_DIR}

SOFT_FLOAT_FALLBACK

)

nrfxlib_calculate_lib_path(NRF_MODEM_LIB_DIR SOC_MODE

BASE_DIR ${CMAKE_CURRENT_SOURCE_DIR}

SOFT_FLOAT_FALLBACK

)

lemrey · 2023-09-26T08:05:56Z

nrf_modem/doc/CHANGELOG.rst

+
+* Added the option to set a timeout for AT commands by calling the :c:func:`nrf_modem_at_sem_timeout_set` function.
+
+:ref:`AT interface <nrf_modem_gnss>`


AT interface -> GNSS

lemrey · 2023-09-26T08:06:28Z

nrf_modem/doc/CHANGELOG.rst

+
+  * Added a DFU callback that will be called after a DFU with the result of the update.
+
+:ref:`Delta DFU <nrf_modem_delta_dfu>`


This should point to the bootloader API

lemrey · 2023-09-26T08:08:08Z

nrf_modem/include/nrf_modem_os.h

@@ -96,7 +96,7 @@ void nrf_modem_os_busywait(int32_t usec);
 *
 * @param context Library context.
 * @param[in, out] timeout Timeout in milliseconds, or @c NRF_MODEM_OS_FOREVER for no timeout.
- *			   Specifies the timeout value on input and the remaining
+ *			   Specifies the timeout value on input and the remainig


This is misspelled now

lemrey · 2023-09-26T10:55:35Z

nrf_modem/doc/CHANGELOG.rst

+:ref:`AT interface <nrf_modem_at>`
+==================================
+
+* Added the option to set a timeout for AT commands by calling the :c:func:`nrf_modem_at_sem_timeout_set` function.


We should rephrase this so that it is clearer that it's not a timeout for AT commands, but rather a timeout for how long AT commands shall wait for ongoing AT commands to complete.

lemrey · 2023-09-26T14:28:12Z

We should include the SoftSIM documentation page, @MirkoCovizzi could you give that to Eivind?

MirkoCovizzi · 2023-09-26T14:30:06Z

nrf_modem/doc/CHANGELOG.rst

+:ref:`Core library <architecture>`
+==================================
+
+* The DFU result is now returned by the :c:param:`dfu_callback` callback in :c:struct:`nrf_modem_init_params` struct.


Suggested change

* The DFU result is now returned by the :c:param:`dfu_callback` callback in :c:struct:`nrf_modem_init_params` struct.

* The DFU result is now returned by the :c:param:`dfu_callback` callback in the :c:struct:`nrf_modem_init_params` struct.

MirkoCovizzi · 2023-09-26T14:31:16Z

nrf_modem/doc/CHANGELOG.rst

+
+* Replaced the :c:macro:`NRF_SO_BINDTODEVICE` socket option with :c:macro:`NRF_SO_BINDTOPDN`. The new option takes an integer for the PDN ID.
+
+


Extra line?

divipillai

Some questions on docs.

nrf_modem/doc/CHANGELOG.rst

lemrey · 2023-09-28T15:03:20Z

nrf_modem/doc/CHANGELOG.rst

+:ref:`AT interface <nrf_modem_at>`
+==================================
+
+* Added the option to set a timeout for the time to wait for ongoing AT commands to complete by calling the :c:func:`nrf_modem_at_sem_timeout_set` function.
+


We are missing one item here, the behavior of nrf_modem_at_cmd_async has changed slightly.

nrf_modem_at_cmd_async will now return immediately if there is another AT command pending.
Earlier, it only returned immediately if there was another AT command pending from an earlier nrf_modem_at_cmd_async call.

Perhaps we can phrase it like so:
nrf_modem_at_cmd_async will now return immediately if there is another AT command pending, regardless of whether it was sent with nrf_modem_at_cmd_async or other API calls.

nrf_modem/doc/softsim_interface.rst

lemrey · 2023-10-03T15:01:45Z

The flowcharts for the updated DFU process look wrong

eivindj-nordic · 2023-10-04T05:52:52Z

The flowcharts for the updated DFU process look wrong

This is when the DFU result is DFU_RES_OK, but the modem fails to initialize afterwards.

nrf_modem/doc/CHANGELOG.rst

See CHANGELOG file for details. Co-authored-by: Mirko Covizzi <[email protected]> Co-authored-by: Tommi Kangas <[email protected]> Co-authored-by: Emanuele Di Santo <[email protected]> Co-authored-by: divya pillai <[email protected]> Signed-off-by: Eivind Jølsgard <[email protected]>

lemrey

Looks good. Thanks for your patience, Divya!

eivindj-nordic requested review from MirkoCovizzi, anhmolt and divipillai September 25, 2023 12:10

eivindj-nordic self-assigned this Sep 25, 2023

eivindj-nordic requested review from rlubos and lemrey as code owners September 25, 2023 12:10

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Sep 25, 2023

eivindj-nordic added this to the 2.5.0 milestone Sep 25, 2023

NordicBuilder mentioned this pull request Sep 25, 2023

manifest: nrf_modem: v2.5.0 release nrfconnect/sdk-nrf#12425

Merged

eivindj-nordic force-pushed the libmodem_v2.5.0 branch from 239d9cb to 2befd73 Compare September 26, 2023 09:54

anhmolt reviewed Sep 26, 2023

View reviewed changes

lemrey reviewed Sep 26, 2023

View reviewed changes

eivindj-nordic force-pushed the libmodem_v2.5.0 branch 2 times, most recently from 06412ad to 99f9f4a Compare September 26, 2023 12:20

MirkoCovizzi reviewed Sep 26, 2023

View reviewed changes

divipillai reviewed Sep 26, 2023

View reviewed changes

nrf_modem/doc/CHANGELOG.rst Show resolved Hide resolved

nrf_modem/doc/CHANGELOG.rst Outdated Show resolved Hide resolved

nrf_modem/doc/CHANGELOG.rst Outdated Show resolved Hide resolved

eivindj-nordic force-pushed the libmodem_v2.5.0 branch 6 times, most recently from c000bcc to 4e3a240 Compare September 27, 2023 13:58

lemrey reviewed Sep 28, 2023

View reviewed changes

eivindj-nordic force-pushed the libmodem_v2.5.0 branch from 4e3a240 to 4430c72 Compare September 28, 2023 18:50

NordicBuilder mentioned this pull request Sep 29, 2023

samples: cellular: http_update: modem DFU samples refactoring nrfconnect/sdk-nrf#11036

Merged

divipillai requested a review from b-gent as a code owner October 2, 2023 10:56

eivindj-nordic commented Oct 2, 2023

View reviewed changes

nrf_modem/doc/softsim_interface.rst Outdated Show resolved Hide resolved

eivindj-nordic force-pushed the libmodem_v2.5.0 branch 2 times, most recently from 8c6796b to 1c1f020 Compare October 2, 2023 11:34

divipillai approved these changes Oct 3, 2023

View reviewed changes

eivindj-nordic force-pushed the libmodem_v2.5.0 branch 5 times, most recently from b7910c1 to da0ec09 Compare October 3, 2023 13:56

eivindj-nordic force-pushed the libmodem_v2.5.0 branch from da0ec09 to e3e4951 Compare October 4, 2023 07:25

lemrey reviewed Oct 4, 2023

View reviewed changes

nrf_modem/doc/CHANGELOG.rst Outdated Show resolved Hide resolved

eivindj-nordic force-pushed the libmodem_v2.5.0 branch from e3e4951 to ed84e8c Compare October 5, 2023 19:26

This was referenced Oct 6, 2023

lib: bin: lwm2m_carrier: update to v3.3.0 nrfconnect/sdk-nrf#12516

Merged

Update GNSS assistance terminology nrfconnect/sdk-nrf#12557

Closed

eivindj-nordic force-pushed the libmodem_v2.5.0 branch from 33bde26 to ce30ae8 Compare October 6, 2023 10:18

lemrey approved these changes Oct 6, 2023

View reviewed changes

eivindj-nordic mentioned this pull request Oct 6, 2023

nrf_modem doc update for nRF9161 #1086

Merged

rlubos approved these changes Oct 6, 2023

View reviewed changes

rlubos merged commit 50e7265 into nrfconnect:main Oct 6, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrf_modem: v2.5.0 release #1079

nrf_modem: v2.5.0 release #1079

eivindj-nordic commented Sep 25, 2023

anhmolt Sep 26, 2023

lemrey Sep 26, 2023

lemrey Sep 26, 2023

lemrey Sep 26, 2023

lemrey Sep 26, 2023

lemrey commented Sep 26, 2023

MirkoCovizzi Sep 26, 2023

MirkoCovizzi Sep 26, 2023

divipillai left a comment

lemrey Sep 28, 2023

lemrey commented Oct 3, 2023

eivindj-nordic commented Oct 4, 2023

lemrey left a comment


		* Added the option to set a timeout for AT commands by calling the :c:func:`nrf_modem_at_sem_timeout_set` function.

		:ref:`AT interface <nrf_modem_gnss>`


		* Added a DFU callback that will be called after a DFU with the result of the update.

		:ref:`Delta DFU <nrf_modem_delta_dfu>`

	* The DFU result is now returned by the :c:param:`dfu_callback` callback in :c:struct:`nrf_modem_init_params` struct.
	* The DFU result is now returned by the :c:param:`dfu_callback` callback in the :c:struct:`nrf_modem_init_params` struct.


		* Replaced the :c:macro:`NRF_SO_BINDTODEVICE` socket option with :c:macro:`NRF_SO_BINDTOPDN`. The new option takes an integer for the PDN ID.

nrf_modem: v2.5.0 release #1079

nrf_modem: v2.5.0 release #1079

Conversation

eivindj-nordic commented Sep 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lemrey commented Sep 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

divipillai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lemrey commented Oct 3, 2023

eivindj-nordic commented Oct 4, 2023

lemrey left a comment

Choose a reason for hiding this comment