modules: hal_nordic: Add multi-instance DPPI and PPIB drivers #79857 #6938
compliance.yml
on: pull_request
Run compliance checks on patch series (PR)
2m 25s
Annotations
4 errors, 1 warning, and 10 notices
Run compliance checks on patch series (PR)
Process completed with exit code 3.
|
Run compliance checks on patch series (PR):
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
Commit 9d0bae6ed2:
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC3 Commit title does not follow [subsystem]: [subject] (and should not start with literal subsys or treewide): "integration hal_nordic branch"
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
|
Run compliance checks on patch series (PR):
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
9d0bae6ed294f759cd4783e19093b13958474fcd: author email (Rafał Kuźnia <[email protected]>) needs to match one of the signed-off-by entries.
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- act_freq = src_freq / prescaler;
+ act_freq = src_freq / prescaler;
File:drivers/audio/dmic_nrfx_pdm.c
Line:163
You may want to run clang-format on this change:
- { 32, NRF_PDM_RATIO_32X },
+ {32, NRF_PDM_RATIO_32X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio48)
- { 48, NRF_PDM_RATIO_48X },
+ {48, NRF_PDM_RATIO_48X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio50)
- { 50, NRF_PDM_RATIO_50X },
-#endif
- { 64, NRF_PDM_RATIO_64X },
- { 80, NRF_PDM_RATIO_80X },
+ {50, NRF_PDM_RATIO_50X},
+#endif
+ {64, NRF_PDM_RATIO_64X}, {80, NRF_PDM_RATIO_80X},
#if defined(PDM_RATIO_RATIO_Ratio96)
- { 96, NRF_PDM_RATIO_96X },
+ {96, NRF_PDM_RATIO_96X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio100)
- { 100, NRF_PDM_RATIO_100X },
+ {100, NRF_PDM_RATIO_100X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio128)
- { 128, NRF_PDM_RATIO_128X }
+ {128, NRF_PDM_RATIO_128X}
File:drivers/audio/dmic_nrfx_pdm.c
Line:293
You may want to run clang-format on this change:
-#define PDM_NRFX_DEVICE(idx) \
- static void *rx_msgs##idx[DT_PROP(PDM(idx), queue_size)]; \
- static struct dmic_nrfx_pdm_drv_data dmic_nrfx_pdm_data##idx; \
- static const nrfx_pdm_t dmic_nrfx_pdm##idx = NRFX_PDM_INSTANCE(idx); \
- static int pdm_nrfx_init##idx(const struct device *dev) \
- { \
- IRQ_CONNECT(DT_IRQN(PDM(idx)), DT_IRQ(PDM(idx), priority), \
- nrfx_isr, nrfx_pdm_##idx##_irq_handler, 0); \
- const struct dmic_nrfx_pdm_drv_cfg *drv_cfg = dev->config; \
- int err = pinctrl_apply_state(drv_cfg->pcfg, \
- PINCTRL_STATE_DEFAULT); \
- if (err < 0) { \
- return err; \
- } \
- dmic_nrfx_pdm_data##idx.pdm = &dmic_nrfx_pdm##idx; \
- k_msgq_init(&dmic_nrfx_pdm_data##idx.rx_queue, \
- (char *)rx_msgs##idx, sizeof(void *), \
- ARRAY_SIZE(rx_msgs##idx)); \
- init_clock_manager(dev); \
- return 0; \
- } \
- static void event_handler##idx(const nrfx_pdm_evt_t *evt) \
- { \
- event_handler(DEVICE_DT_GET(PDM(idx)), evt); \
- } \
- PINCTRL_DT_DEFINE(PDM(idx)); \
- static const struct dmic_nrfx_pdm_drv_cfg dmic_nrfx_pdm_cfg##idx = { \
- .event_handler = event_handler##idx, \
- .nrfx_def_cfg = NRFX_PDM_DEFAULT_CONFIG(0, 0), \
- .nrfx_def_cfg.skip_gpio_cfg = true, \
- .nrfx_def_cfg.skip_psel_cfg = true, \
- .pcfg = PINCTRL_DT_DEV_CONFIG_GET(PDM(idx)), \
- .clk_src = PDM_CLK_SRC(idx), \
- }; \
- BUILD_ASSERT(PDM_CLK_SRC(idx) != ACLK || NRF_PDM_HAS_MCLKCONFIG, \
- "Clock source ACLK is not available."); \
- BUILD_ASSERT(PDM_CLK_SRC(idx) != ACLK || \
- DT_NODE_HAS_PROP(DT_NODELABEL(clock), \
- hfclkaudio_frequency), \
- "Clock source ACLK requires the hfclkaudio-frequency " \
- "property to be defined in the nordic,nrf-clock node."); \
- DEVICE_DT_DEFINE(PDM(idx), pdm_nrfx_init##idx, NULL, \
- &dmic_nrfx_pdm_data##idx, &dmic_nrfx_pdm_cfg##idx, \
- POST_KERNEL, CONFIG_AUDIO_DMIC_INIT_PRIORITY, \
+#define PDM_NRFX_DEVICE(idx) \
+ static void *rx_msgs##idx[DT_PROP(PDM(idx), queue_size)]; \
+ static struct dmic_nrfx_pdm_drv_data dmic_nrfx_pdm_data##idx; \
+ static const nrfx_pdm_t dmic_nrfx_pdm##idx = NRFX_PDM_INSTANCE(idx); \
+ static int pdm_nrfx_init##idx(const struct device *dev) \
+ { \
+ IRQ_CONNECT(DT_IRQN(PDM(idx)), DT_IRQ(PDM(idx), priority), nrfx_isr, \
+ nrfx_pdm_##idx##_irq_handler, 0); \
+ const struct dmic_nrfx_pdm_drv_cfg *drv_cfg =
|
You may want to run clang-format on this change:
drivers/audio/dmic_nrfx_pdm.c#L163
drivers/audio/dmic_nrfx_pdm.c:163
- act_freq = src_freq / prescaler;
+ act_freq = src_freq / prescaler;
|
You may want to run clang-format on this change:
drivers/audio/dmic_nrfx_pdm.c#L293
drivers/audio/dmic_nrfx_pdm.c:293
- { 32, NRF_PDM_RATIO_32X },
+ {32, NRF_PDM_RATIO_32X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio48)
- { 48, NRF_PDM_RATIO_48X },
+ {48, NRF_PDM_RATIO_48X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio50)
- { 50, NRF_PDM_RATIO_50X },
-#endif
- { 64, NRF_PDM_RATIO_64X },
- { 80, NRF_PDM_RATIO_80X },
+ {50, NRF_PDM_RATIO_50X},
+#endif
+ {64, NRF_PDM_RATIO_64X}, {80, NRF_PDM_RATIO_80X},
#if defined(PDM_RATIO_RATIO_Ratio96)
- { 96, NRF_PDM_RATIO_96X },
+ {96, NRF_PDM_RATIO_96X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio100)
- { 100, NRF_PDM_RATIO_100X },
+ {100, NRF_PDM_RATIO_100X},
#endif
#if defined(PDM_RATIO_RATIO_Ratio128)
- { 128, NRF_PDM_RATIO_128X }
+ {128, NRF_PDM_RATIO_128X}
|
You may want to run clang-format on this change:
drivers/audio/dmic_nrfx_pdm.c#L638
drivers/audio/dmic_nrfx_pdm.c:638
-#define PDM_NRFX_DEVICE(idx) \
- static void *rx_msgs##idx[DT_PROP(PDM(idx), queue_size)]; \
- static struct dmic_nrfx_pdm_drv_data dmic_nrfx_pdm_data##idx; \
- static const nrfx_pdm_t dmic_nrfx_pdm##idx = NRFX_PDM_INSTANCE(idx); \
- static int pdm_nrfx_init##idx(const struct device *dev) \
- { \
- IRQ_CONNECT(DT_IRQN(PDM(idx)), DT_IRQ(PDM(idx), priority), \
- nrfx_isr, nrfx_pdm_##idx##_irq_handler, 0); \
- const struct dmic_nrfx_pdm_drv_cfg *drv_cfg = dev->config; \
- int err = pinctrl_apply_state(drv_cfg->pcfg, \
- PINCTRL_STATE_DEFAULT); \
- if (err < 0) { \
- return err; \
- } \
- dmic_nrfx_pdm_data##idx.pdm = &dmic_nrfx_pdm##idx; \
- k_msgq_init(&dmic_nrfx_pdm_data##idx.rx_queue, \
- (char *)rx_msgs##idx, sizeof(void *), \
- ARRAY_SIZE(rx_msgs##idx)); \
- init_clock_manager(dev); \
- return 0; \
- } \
- static void event_handler##idx(const nrfx_pdm_evt_t *evt) \
- { \
- event_handler(DEVICE_DT_GET(PDM(idx)), evt); \
- } \
- PINCTRL_DT_DEFINE(PDM(idx)); \
- static const struct dmic_nrfx_pdm_drv_cfg dmic_nrfx_pdm_cfg##idx = { \
- .event_handler = event_handler##idx, \
- .nrfx_def_cfg = NRFX_PDM_DEFAULT_CONFIG(0, 0), \
- .nrfx_def_cfg.skip_gpio_cfg = true, \
- .nrfx_def_cfg.skip_psel_cfg = true, \
- .pcfg = PINCTRL_DT_DEV_CONFIG_GET(PDM(idx)), \
- .clk_src = PDM_CLK_SRC(idx), \
- }; \
- BUILD_ASSERT(PDM_CLK_SRC(idx) != ACLK || NRF_PDM_HAS_MCLKCONFIG, \
- "Clock source ACLK is not available."); \
- BUILD_ASSERT(PDM_CLK_SRC(idx) != ACLK || \
- DT_NODE_HAS_PROP(DT_NODELABEL(clock), \
- hfclkaudio_frequency), \
- "Clock source ACLK requires the hfclkaudio-frequency " \
- "property to be defined in the nordic,nrf-clock node."); \
- DEVICE_DT_DEFINE(PDM(idx), pdm_nrfx_init##idx, NULL, \
- &dmic_nrfx_pdm_data##idx, &dmic_nrfx_pdm_cfg##idx, \
- POST_KERNEL, CONFIG_AUDIO_DMIC_INIT_PRIORITY, \
+#define PDM_NRFX_DEVICE(idx) \
+ static void *rx_msgs##idx[DT_PROP(PDM(idx), queue_size)]; \
+ static struct dmic_nrfx_pdm_drv_data dmic_nrfx_pdm_data##idx; \
+ static const nrfx_pdm_t dmic_nrfx_pdm##idx = NRFX_PDM_INSTANCE(idx); \
+ static int pdm_nrfx_init##idx(const struct device *dev) \
+ { \
+ IRQ_CONNECT(DT_IRQN(PDM(idx)), DT_IRQ(PDM(idx), priority), nrfx_isr, \
+ nrfx_pdm_##idx##_irq_handler, 0); \
+ const struct dmic_nrfx_pdm_drv_cfg *drv_cfg = dev->config; \
+ int err = pinctrl_apply_state(drv_cfg->pcfg, PINCTRL_STATE_DEFAULT); \
+ if (err < 0) { \
+ return err; \
+ } \
+ dmic_nrfx_pdm_data##idx.pdm = &dmic_nrfx_pdm##idx; \
+ k_msgq_init(&dmic_nrfx_pdm_data##idx.rx_queue, (char *)rx_msgs##idx, \
+ sizeof(void *), ARRAY_SIZE(rx_msgs##idx)); \
+ init_clock_manager(dev); \
+ return 0; \
+ } \
+ static void event_handler##idx(const nrfx_pdm_evt_t *evt) \
+ {
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L120
drivers/serial/uart_nrfx_uarte.c:120
- uint32_t total_byte_cnt; /* Total number of bytes received */
+ uint32_t total_byte_cnt; /* Total number of bytes received */
uint32_t total_user_byte_cnt; /* Total number of bytes passed to user */
- int32_t timeout; /* Timeout set by user */
- int32_t timeout_slab; /* rx_timeout divided by RX_TIMEOUT_DIV */
- int32_t timeout_left; /* Current time left until user callback */
+ int32_t timeout; /* Timeout set by user */
+ int32_t timeout_slab; /* rx_timeout divided by RX_TIMEOUT_DIV */
+ int32_t timeout_left; /* Current time left until user callback */
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L189
drivers/serial/uart_nrfx_uarte.c:189
-#define UARTE_CFG_FLAG_PPI_ENDTX BIT(0)
+#define UARTE_CFG_FLAG_PPI_ENDTX BIT(0)
/* If enabled then TIMER and PPI is used for byte counting. */
-#define UARTE_CFG_FLAG_HW_BYTE_COUNTING BIT(1)
+#define UARTE_CFG_FLAG_HW_BYTE_COUNTING BIT(1)
/* If enabled then UARTE peripheral is disabled when not used. This allows
* to achieve lowest power consumption in idle.
*/
-#define UARTE_CFG_FLAG_LOW_POWER BIT(2)
+#define UARTE_CFG_FLAG_LOW_POWER BIT(2)
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L788
drivers/serial/uart_nrfx_uarte.c:788
- struct uart_event evt = {
- .type = UART_RX_RDY,
- .data.rx.buf = data->async->rx.buf,
- .data.rx.len = len,
- .data.rx.offset = data->async->rx.offset
- };
+ struct uart_event evt = {.type = UART_RX_RDY,
+ .data.rx.buf = data->async->rx.buf,
+ .data.rx.len = len,
+ .data.rx.offset = data->async->rx.offset};
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L996
drivers/serial/uart_nrfx_uarte.c:996
- int32_t len = data->async->rx.total_byte_cnt
- - data->async->rx.total_user_byte_cnt;
+ int32_t len = data->async->rx.total_byte_cnt - data->async->rx.total_user_byte_cnt;
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L1025
drivers/serial/uart_nrfx_uarte.c:1025
- if (clipped ||
- (data->async->rx.timeout_left
- < data->async->rx.timeout_slab)) {
+ if (clipped || (data->async->rx.timeout_left < data->async->rx.timeout_slab)) {
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L1034
drivers/serial/uart_nrfx_uarte.c:1034
- data->async->rx.timeout_left -=
- data->async->rx.timeout_slab;
+ data->async->rx.timeout_left -= data->async->rx.timeout_slab;
|
You may want to run clang-format on this change:
drivers/serial/uart_nrfx_uarte.c#L1079
drivers/serial/uart_nrfx_uarte.c:1079
- k_timer_start(&data->async->rx.timer,
- K_USEC(data->async->rx.timeout_slab),
+ k_timer_start(&data->async->rx.timer, K_USEC(data->async->rx.timeout_slab),
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
compliance.xml
|
3.43 KB |
|