chore(charts): fix testing install

nrwl · Feb 29, 2024 · 6570e50 · 6570e50
1 parent 1a9462d
commit 6570e50
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/chart_lint_and_test.yaml b/.github/workflows/chart_lint_and_test.yaml
@@ -44,6 +44,7 @@ jobs:
         if: steps.list-changed.outputs.changed == 'true'
         run: |
           cp testing-files/secret.yml charts/nx-cloud/templates/secret.yaml
+          cp testing-files/secret.yml charts/nx-agents/templates/secret.yaml
 
       - name: Run chart-testing (install)
         if: steps.list-changed.outputs.changed == 'true'

diff --git a/.gitignore b/.gitignore
@@ -3,4 +3,5 @@
 
 # We copy this over on automated testing but for local we need to copy it in so ignore
 # if someone forgets to delete before pushing
-charts/nx-cloud/templates/secret.yml
+charts/nx-cloud/templates/secret.yml
+charts/nx-agents/templates/secret.yml
diff --git a/charts/nx-agents/ci/basic-moreenv.yaml b/charts/nx-agents/ci/basic-moreenv.yaml
@@ -67,5 +67,5 @@ daemonset:
 
 secret:
   name: 'cloudsecret'
-  awsS3AccessKeyId: 'ABC123556'
-  awsS3SecretAccessKey: 'BBBAAA1234'
+  awsS3AccessKeyId: 'AWS_KEY'
+  awsS3SecretAccessKey: 'AWS_SECRET'
diff --git a/charts/nx-agents/ci/basic-values.yaml b/charts/nx-agents/ci/basic-values.yaml
@@ -58,5 +58,5 @@ daemonset:
 
 secret:
   name: 'cloudsecret'
-  awsS3AccessKeyId: 'ABC123556'
-  awsS3SecretAccessKey: 'BBBAAA1234'
+  awsS3AccessKeyId: 'AWS_KEY'
+  awsS3SecretAccessKey: 'AWS_SECRET'
diff --git a/testing-files/secret.yml b/testing-files/secret.yml
@@ -3,6 +3,7 @@ apiVersion: v1
 kind: Secret
 metadata:
   name: cloudsecret
+  namespace: {{ .Values.global.namespace }}
 type: Opaque
 stringData:
   NX_CLOUD_MONGO_SERVER_ENDPOINT: "mongodb://127.0.0.1"
@@ -17,4 +18,6 @@ stringData:
   GITHUB_WEBHOOK_SECRET: "A_GITHUB_SECRET_VALUE"
   GITHUB_AUTH_TOKEN: "A_GITHUB_SECRET_VALUE"
   GITHUB_APP_PRIVATE_KEY: "A_GITHUB_SECRET_VALUE"
-  GITHUB_APP_ID: "A_GITHUB_SECRET_VALUE"
+  GITHUB_APP_ID: "A_GITHUB_SECRET_VALUE"
+  AWS_KEY: "MYAWSKEY"
+  AWS_SECRET: "SUPER_SECRET_AWS_SECRET"