fix: add envFrom for frontend and api deployments

nrwl · Oct 6, 2024 · f22b682 · f22b682
1 parent 843229a
commit f22b682
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/charts/nx-cloud/Chart.yaml b/charts/nx-cloud/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: nx-cloud
 description: Nx Cloud Helm Chart
 type: application
-version: 0.15.12
+version: 0.15.13
 maintainers:
   - name: nx
     url: "https://nx.app/"

diff --git a/charts/nx-cloud/templates/nx-cloud-frontend-deployment.yaml b/charts/nx-cloud/templates/nx-cloud-frontend-deployment.yaml
@@ -96,6 +96,10 @@ spec:
                     {{- end }}
             {{- end }}
         {{- end }}
+          {{- if .Values.frontend.deployment.envFrom }}
+          envFrom:
+            {{- toYaml .Values.frontend.deployment.envFrom | nindent 12 }}
+          {{- end }}
       {{- if .Values.selfSignedCertConfigMap }}
       volumes:
         - configMap:

diff --git a/charts/nx-cloud/templates/nx-cloud-nx-api-deployment.yaml b/charts/nx-cloud/templates/nx-cloud-nx-api-deployment.yaml
@@ -152,6 +152,10 @@ spec:
             - name: NX_CLOUD_USE_MONGO42
               value: 'false'
         {{- end }}
+          {{- if .Values.nxApi.deployment.envFrom }}
+          envFrom:
+            {{- toYaml .Values.nxApi.deployment.envFrom | nindent 12 }}
+          {{- end }}
       {{- if .Values.selfSignedCertConfigMap }}
       volumes:
         - emptyDir: { }

diff --git a/charts/nx-cloud/values.yaml b/charts/nx-cloud/values.yaml
@@ -31,6 +31,7 @@ frontend:
     replicas: 1
     port: 4202
     env: []
+    envFrom: []
   service:
     name: nx-cloud-frontend-service
     type: ClusterIP
@@ -55,6 +56,7 @@ nxApi:
     replicas: 1
     port: 4203
     env: []
+    envFrom: []
     readinessProbe: {}
   service:
     name: nx-cloud-nx-api-service
@@ -233,6 +235,8 @@ secret:
   githubAuthClientSecret: ''
   githubWebhookSecret: ''
   githubAuthToken: ''
+  githubAppClientId: ''
+  githubAppClientSecret: ''
   githubAppId: ''
   githubPrivateKey: ''
   gitlabAccessToken: ''