Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add envFrom for frontend and api deployments #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add envFrom for frontend and api deployments #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nx-cloud/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: nx-cloud
description: Nx Cloud Helm Chart
type: application
version: 0.15.12
version: 0.15.13
maintainers:
- name: nx
url: "https://nx.app/"
Expand Down
4 changes: 4 additions & 0 deletions charts/nx-cloud/templates/nx-cloud-frontend-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- if .Values.frontend.deployment.envFrom }}
envFrom:
{{- toYaml .Values.frontend.deployment.envFrom | nindent 12 }}
{{- end }}
{{- if .Values.selfSignedCertConfigMap }}
volumes:
- configMap:
Expand Down
4 changes: 4 additions & 0 deletions charts/nx-cloud/templates/nx-cloud-nx-api-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ spec:
- name: NX_CLOUD_USE_MONGO42
value: 'false'
{{- end }}
{{- if .Values.nxApi.deployment.envFrom }}
envFrom:
{{- toYaml .Values.nxApi.deployment.envFrom | nindent 12 }}
{{- end }}
{{- if .Values.selfSignedCertConfigMap }}
volumes:
- emptyDir: { }
Expand Down
4 changes: 4 additions & 0 deletions charts/nx-cloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ frontend:
replicas: 1
port: 4202
env: []
envFrom: []
service:
name: nx-cloud-frontend-service
type: ClusterIP
Expand All @@ -55,6 +56,7 @@ nxApi:
replicas: 1
port: 4203
env: []
envFrom: []
readinessProbe: {}
service:
name: nx-cloud-nx-api-service
Expand Down Expand Up @@ -233,6 +235,8 @@ secret:
githubAuthClientSecret: ''
githubWebhookSecret: ''
githubAuthToken: ''
githubAppClientId: ''
githubAppClientSecret: ''
githubAppId: ''
githubPrivateKey: ''
gitlabAccessToken: ''
Expand Down
Loading