Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle differently namespaces controller services #91

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

rarmatei
Copy link
Collaborator

@rarmatei rarmatei commented Jan 18, 2024

Currently, on snapshot we use an external name service, which is deployed in the default namespace. If we specify we want a default name service for our workflow config, we should use the default namespace, otherwise, we should use whatever namespace the workflows are deployed in.

@rarmatei rarmatei merged commit 425bed3 into main Jan 18, 2024
1 check passed
@rarmatei rarmatei deleted the rarmatei-patch-2 branch January 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants