Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files in dist #99

Closed
eternalmatt opened this issue Jul 26, 2023 · 4 comments
Closed

Remove unused files in dist #99

eternalmatt opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@eternalmatt
Copy link

eternalmatt commented Jul 26, 2023

Hello Nx team! I would like to use this module, however the security scanning software at my company has detected unsecure versions of vm2 presumably from dist/bridge.js

vm2 has the following problems:

Suggestion

Re-generate dist without any extra files.

rm -r dist
npm run build

I tried this once on my side and it only generates 2 files

> build
> ncc build find-successful-workflow.js --license licenses.txt

ncc: Version 0.34.0
ncc: Compiling file index.js into CJS
 41kB  dist\licenses.txt
757kB  dist\index.js
798kB  [1470ms] - ncc 0.34.0
@janeklb
Copy link
Contributor

janeklb commented Aug 1, 2023

There seems to be some undocumented process that produces those files. I don't think that they're required for any consumers of the github action, but the last commit that changes anything in dist changes everything in dist (and the readme / instructions remain the same)

@meeroslav
Copy link
Collaborator

These files were needed for the old versions of the node. We are bumping the requirement to node v18 (v16 EOL is in 6 days, and v14 is a long time expired).

@meeroslav meeroslav added the feature New feature or request label Sep 6, 2023
@meeroslav
Copy link
Collaborator

Resolved by #109

@eternalmatt
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants