feat: increase minimum node version to v18 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeroslav
force-pushed
the
switch-to-yarn
branch
2 times, most recently
from
636da76
to
ea2b97a
Compare
meeroslav
changed the title
meeroslav
force-pushed
the
switch-to-yarn
branch
3 times, most recently
from
34a925c
to
3e39ef6
Compare
meeroslav
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
meeroslav
force-pushed
the
switch-to-yarn
branch
from
3e39ef6
to
ae8882d
Compare
JamesHenry
reviewed
Sep 6, 2023
JamesHenry
reviewed
Sep 6, 2023
JamesHenry
reviewed
Sep 6, 2023
JamesHenry
changed the title
|
Summary of what we discussed: Because this is a This means that all we can do on our side is express our desired minimum supported version and build and test using that version to ensure the best chance of compatibility. Given Node 18 will still be supported for another year, and some popular tools out there still do not explicitly support Node 20 it is safer for us to stick with 18 for now. |
JamesHenry
approved these changes
Sep 6, 2023
meeroslav
force-pushed
the
switch-to-yarn
branch
from
b619578
to
99f90a4
Compare
meeroslav
force-pushed
the
switch-to-yarn
branch
from
99f90a4
to
a269dba
Compare
meeroslav
force-pushed
the
switch-to-yarn
branch
from
8d29056
to
6d91abe
Compare
meeroslav
force-pushed
the
switch-to-yarn
branch
from
6d91abe
to
d066b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.