Switch to JS Action #163
Switch to JS Action #163
Conversation
|
If you want me to I could use more of the GitHub provided TypeScript-Action-Template … |
|
Anything I can do to move this along? |
|
Hi @joh-klein ! I merged your other PR , THANK you! As for this PR, this looks like quite a big change, and may be disruptive to some ppl that are using this package? Even though I understand you have kept the functionality intact, it seems like lots of changes. What is the main reason you think we should switch to a JS Action? What limitations do you think the current setup has? I know I asked you to create a PR back in June, but on second thoughts, and seeing the PR, I am not sure I can justify the switch. I do hope you understand my concerns, and be sure that I 100% appreciate the time you put into this. Is the motivation for the change just the easier way to get the inputs? Or is there more things as well that this change would serve? |
In this PR I changed the action to a "JavaScript action" (as I offered in #158) - this will make it easier to handle additional inputs.
I tried to keep the change as small as possible and not add any additional ideas.
What I haven't tried is the release/publish step.