Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): create new workspaces with ESLint v9 and typescript-eslint v8 #27404

Merged
merged 41 commits into from
Sep 12, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Aug 13, 2024

Closes #27451

@JamesHenry JamesHenry self-assigned this Aug 13, 2024
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 6:38pm

@JamesHenry JamesHenry mentioned this pull request Aug 13, 2024
@JamesHenry JamesHenry force-pushed the eslint-v9-for-new-workspaces branch 2 times, most recently from 306be07 to 7e00ad8 Compare August 14, 2024 15:50
@JamesHenry JamesHenry changed the title feat(linter): wip feat(linter): create new workspaces with ESLint v9 and typescript-eslint v8 Aug 15, 2024
@jaysoo jaysoo force-pushed the eslint-v9-for-new-workspaces branch 4 times, most recently from 4644e50 to 07033de Compare August 28, 2024 18:30
@jaysoo jaysoo force-pushed the eslint-v9-for-new-workspaces branch 2 times, most recently from c7e237e to e9806c6 Compare September 5, 2024 21:30
@jaysoo jaysoo marked this pull request as ready for review September 5, 2024 21:30
@jaysoo jaysoo force-pushed the eslint-v9-for-new-workspaces branch from 6fe2831 to 71fc56e Compare September 9, 2024 19:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this eslint version has not been updated yet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of this PR is not to update the Nx repo itself to use ESLint v9. That will come later.

@jaysoo jaysoo force-pushed the eslint-v9-for-new-workspaces branch 2 times, most recently from ad15a9c to 00130f5 Compare September 11, 2024 03:49
@nrwl nrwl deleted a comment from github-actions bot Sep 11, 2024
@nrwl nrwl deleted a comment from github-actions bot Sep 11, 2024
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-27404-9b7456c
Release details 📑
Published version 0.0.0-pr-27404-9b7456c
Triggered by @jaysoo
Branch eslint-v9-for-new-workspaces
Commit 9b7456c
Workflow run 10817714102

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@nrwl nrwl deleted a comment from github-actions bot Sep 11, 2024
@jaysoo jaysoo merged commit 68eeb2e into master Sep 12, 2024
6 checks passed
@jaysoo jaysoo deleted the eslint-v9-for-new-workspaces branch September 12, 2024 20:02
@robertIsaac
Copy link
Contributor

hi @JamesHenry
first of all thank you so much for completing the work for this
but I have a question
why in the new project now it doesn't use tseslint.config function e.g.

const nx = require('@nx/eslint-plugin');
const tsEslint = require('typescript-eslint');

module.exports = tsEslint.config(
  ...nx.configs['flat/base'],
...

instead of now

const nx = require('@nx/eslint-plugin');

module.exports = [
  ...nx.configs['flat/base'],
...

as it provides help assistance when you try to modify the file

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new workspaces with ESLint v9 and typescript-eslint v8
5 participants