Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): generated tsconfig extends path #28317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastienGllmt
Copy link

Current Behavior

The generated extends path in tsconfig is incorrectly generated, causing the build to succeed even if it does nothing

Expected Behavior

The paths should either both be absolute, or both be relative.

The easiest way to do this was to pass in the relative path into the checkDependencies function (since the tsConfig variable is not accessed anywhere except to calculate generatedTsConfig.extends), but changing dirnameTsConfig to always be absolute would also be okay

Related Issue(s)

Fixes #28316

@SebastienGllmt SebastienGllmt requested a review from a team as a code owner October 6, 2024 11:43
Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 11:46am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/js:tsc - wrong extends path used when generated temporary tsconfig
1 participant