fix(js): generated tsconfig extends path #28317
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The generated
extends
path in tsconfig is incorrectly generated, causing the build to succeed even if it does nothingExpected Behavior
The paths should either both be absolute, or both be relative.
The easiest way to do this was to pass in the relative path into the
checkDependencies
function (since thetsConfig
variable is not accessed anywhere except to calculategeneratedTsConfig.extends
), but changingdirnameTsConfig
to always be absolute would also be okayRelated Issue(s)
Fixes #28316