Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS and Insecure can be set per device in config yaml #145

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

klaper
Copy link
Contributor

@klaper klaper commented Jun 4, 2022

  • Adds port (default 8728) setting to device setting in config file
  • Adds tls (default: false) option to device settings in config file
  • Adds insecure (default: false) option to device settings in config file
  • Moves tls and insecure connection options settings from collector to device, allowing to have mixed connections for devices in yaml config file
  • updates README.md

@nshttpd
Copy link
Owner

nshttpd commented Jun 17, 2022

Thanks @klaper. I like this PR in practice, but how bad will it break all the existing configs out there in the wild?

@klaper
Copy link
Contributor Author

klaper commented Jun 18, 2022

Before there was no possibility to set port or TLS. Since all added settings are optional with defaults set to same values as before, this change should have no effect on any of current configs (including those provided with command line).

@klaper
Copy link
Contributor Author

klaper commented Nov 25, 2022

@nshttpd any news :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants