Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Child objects ACL #437

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix/Child objects ACL #437

merged 2 commits into from
Feb 13, 2024

Conversation

carpawell
Copy link
Member

No description provided.

@carpawell carpawell self-assigned this Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (70b1ffb) 63.78% compared to head (cca9610) 63.71%.

Files Patch % Lines
object/link.go 74.22% 17 Missing and 8 partials ⚠️
object/convert.go 40.00% 10 Missing and 2 partials ⚠️
object/types.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   63.78%   63.71%   -0.08%     
==========================================
  Files          75       76       +1     
  Lines        9397     9530     +133     
==========================================
+ Hits         5994     6072      +78     
- Misses       2686     2731      +45     
- Partials      717      727      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carpawell carpawell force-pushed the fix/small-objects-acl branch 3 times, most recently from cd157cf to 2323318 Compare February 1, 2024 17:15
@carpawell carpawell marked this pull request as ready for review February 1, 2024 17:15
Includes protoc-gen-go version sync.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell force-pushed the fix/small-objects-acl branch 2 times, most recently from b5951e7 to cac1348 Compare February 6, 2024 21:08
roman-khimov
roman-khimov previously approved these changes Feb 6, 2024
Includes stable marshaling, testing and a few convenient helper funcs.

Signed-off-by: Pavel Karpy <[email protected]>
@roman-khimov roman-khimov merged commit 853ee3d into master Feb 13, 2024
5 of 7 checks passed
@roman-khimov roman-khimov deleted the fix/small-objects-acl branch February 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants