feat/Add metrics per container and per shard #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
feat/add-metrics-for-payload
branch
from
ff7586b
to
22fd58b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2437 +/- ##
==========================================
+ Coverage 29.41% 29.43% +0.02%
==========================================
Files 399 399
Lines 30346 30384 +38
==========================================
+ Hits 8925 8945 +20
- Misses 20680 20696 +16
- Partials 741 743 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| payloadSize = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | ||
| Namespace: storageNodeNameSpace, | ||
| Subsystem: engineSubsystem, | ||
| Name: "payload_size", |
There was a problem hiding this comment.
this name seems to generic to me, how about shard_payload_size/volume?
There was a problem hiding this comment.
it will always have a "shard" label valued with its ID. do you still think it is required (i dont mind just confirm it, please)?
There was a problem hiding this comment.
if shard will be mentioned, then it's ok
carpawell
force-pushed
the
feat/add-metrics-for-payload
branch
from
22fd58b
to
8a60360
Compare
carpawell
force-pushed
the
feat/add-metrics-for-payload
branch
from
8a60360
to
fc51eb8
Compare
cthulhu-rider
approved these changes
Jul 21, 2023
roman-khimov
approved these changes
Jul 21, 2023
No need to store everything in a `map` but at the same time, it makes things more complex. Signed-off-by: Pavel Karpy <[email protected]>
Closes nspcc-dev#2116. Signed-off-by: Pavel Karpy <[email protected]>
Closes nspcc-dev#2023. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
feat/add-metrics-for-payload
branch
from
fc51eb8
to
c97e432
Compare
roman-khimov
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.