-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean code #2945
Clean code #2945
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2945 +/- ##
==========================================
- Coverage 23.89% 23.88% -0.01%
==========================================
Files 776 776
Lines 45888 45899 +11
==========================================
- Hits 10963 10962 -1
- Misses 34064 34073 +9
- Partials 861 864 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure 1st commit closes the entire issue?
dont insist, but i'd squash all commits into one - fixing all linting remarks
Please don't. They're nice this way, each commit fixing some linter of its own. Really easy to look through. |
too personal and doubtful. In opposite, to me, service commits make it more difficult to navigate foundational changes |
Each commit solves some problem of its own, no doubt it's better. |
having lint action failures -> no failures - this is the most reasonable atomic problem statement for this project to me. And 20 linter-related commits taking up the entire screen is just a distraction finally, my point remains, but since the work of separation has been done, let it remain too |
Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Update to `math/rand/v2` and use `crypto/rand` for `rand.Read`. Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Error: `struct literal uses unkeyed fields`. Signed-off-by: Andrey Butusov <[email protected]>
Errors: `S1023: redundant `return` statement` and `S1019: should use make(chan *Move) instead`. Signed-off-by: Andrey Butusov <[email protected]>
Error: `duplicated-imports`. Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Error: `Comment should end in a period`. Signed-off-by: Andrey Butusov <[email protected]>
Error: `SA4004: the surrounding loop is unconditionally terminated`. Signed-off-by: Andrey Butusov <[email protected]>
Errors: `unnecessary leading newline` and `unnecessary trailing newline`. Signed-off-by: Andrey Butusov <[email protected]>
Error: `for loop can be changed to use an integer range (Go 1.22+)`. Signed-off-by: Andrey Butusov <[email protected]>
Error: `Error return value is not checked`. Signed-off-by: Andrey Butusov <[email protected]>
Error: `Non-wrapping format verb for fmt.Errorf. Use `%w` to format errors` and `comparing with != || == will fail on wrapped errors. Use errors.Is to check for a specific error`. Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Refs #2943.