Add --global-name flag for neofs-cli container create
#2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
End-rey
force-pushed
the
2682-named-container
branch
from
f335d70
to
37eb0a2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2954 +/- ##
==========================================
+ Coverage 23.53% 23.54% +0.01%
==========================================
Files 776 776
Lines 46602 46606 +4
==========================================
+ Hits 10967 10973 +6
Misses 34772 34772
+ Partials 863 861 -2 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
2682-named-container
branch
from
37eb0a2
to
b665b62
Compare
cthulhu-rider
approved these changes
Sep 30, 2024
End-rey
force-pushed
the
2682-named-container
branch
from
b665b62
to
f76ccb2
Compare
If `--global-name` provided, then name attribute sets to `__NEOFS__NAME` attribute, which is used for container domain name in NNS contracts. Closes #2682. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
2682-named-container
branch
from
f76ccb2
to
524f471
Compare
roman-khimov
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #2682 (comment), rewrite #2950.
Closes #2682.