ir/config: assign default to missing port in TCP addresses #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
- Coverage 23.47% 23.02% -0.45%
==========================================
Files 780 780
Lines 46655 58208 +11553
==========================================
+ Hits 10953 13404 +2451
- Misses 34833 43936 +9103
+ Partials 869 868 -1 ☔ View full report in Codecov by Sentry. |
carpawell
approved these changes
Oct 19, 2024
Use default port `:20333` to P2P protocol: - morph.consensus.seed_nodes - morph.consensus.p2p.listen and `:30333` to listen RPC: - morph.consensus.rpc.listen - morph.consensus.rpc.tls.listen Closes #2420. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
2420-missing-port-in-address
branch
from
0cc9917
to
cbeac51
Compare
roman-khimov
approved these changes
Oct 21, 2024
cthulhu-rider
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2420.
Is it necessary to document default ports, except the example config?