diskqueue: support a callback when the disk queue is empty #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
approved these changes
Dec 1, 2020
| } | ||
|
|
||
| // New instantiates an instance of diskQueue, retrieving metadata | ||
| // from the filesystem and starting the read ahead goroutine | ||
| func New(name string, dataPath string, maxBytesPerFile int64, | ||
| minMsgSize int32, maxMsgSize int32, | ||
| syncEvery int64, syncTimeout time.Duration, logf AppLogFunc) Interface { | ||
| syncEvery int64, syncTimeout time.Duration, logf AppLogFunc, cb EmptyCallback) Interface { |
There was a problem hiding this comment.
I have quibbles with the naming here ... the type EmptyCallback func() initially sounds to me like it is describing the callback taking no arguments and returning nothing. I lean towards just queueEmptyCB func() (no extra type).
It's a bit annoying that we have to break compatibility when adding optional arguments here. Already did that for logf though, and not sure want to redesign with a DiskQueueOptions struct or similar, right now.
|
I thought i would need this feedback loop - but i'm not currently using it in nsqio/nsq#1305 (still a WIP so somewhat subject to change) - that means I might just end up closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports nsqio/nsq#1305