Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set topology region+zone and send in IDENTIFY msg #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set topology region+zone and send in IDENTIFY msg #312

wants to merge 1 commit into from

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Nov 21, 2020

This supports nsqio/nsq#1300 by providing a way to send topology information to nsqd

@jehiah jehiah self-assigned this Nov 21, 2020
@jehiah jehiah mentioned this pull request Nov 21, 2020
Open
ploxiln
ploxiln approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@ploxiln ploxiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple :)

@mreiferson
Copy link
Member

This diff is obviously fine, but let's finish discussing the design and architecture for this group of changes before landing.

@jehiah jehiah mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoemccormick zoemccormick zoemccormick approved these changes

@Ulminator Ulminator Ulminator approved these changes

@ploxiln ploxiln ploxiln approved these changes

Assignees

@jehiah jehiah

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jehiah @mreiferson @ploxiln @Ulminator @zoemccormick