Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqadmin: fix counter view #1467

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

dudleycarr
Copy link
Contributor

Fixes #747

Two bugs are addressed on the counter view:

  1. The increment counter animation is unbounded, causing the counter to exceed the true message processing count. The counter jumps back to the true message processing count after the API poll request.
  2. The message processed graph below the counter doesn't properly handle the timeframe selector. The graph briefly updates when selecting the new timeframe but reverts to the timeframe at page load after the next API poll request.

Video below shows the first bug in the nsqadmin running on 4171. The nsqadmin on 4181 has the PR fix.

Screen.Recording.2023-10-25.at.6.18.32.AM.mov

Use lastNum instead of remainder

Add nsqadmin build artifacts
@jehiah
Copy link
Member

jehiah commented Oct 25, 2023

I haven't looked at this page recently... it's always a blast to see. Below from one of my clusters.

Screenshot 2023-10-25 at 9 43 45 AM

@jehiah jehiah added the bug label Oct 25, 2023
@jehiah jehiah changed the title Fix nsqadmin counter view nsqadmin: fix counter view Oct 25, 2023
@jehiah jehiah merged commit 30998dd into nsqio:master Oct 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nsqadmin: counter goes backwards sometimes
2 participants