Refactor switch statement to simplify

nswdpc · Aug 14, 2024 · a32f8bb · a32f8bb
1 parent 41f7442
commit a32f8bb
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/src/Connector/Message.php b/src/Connector/Message.php
@@ -137,20 +137,13 @@ protected function sendMessage(array $parameters)
         // send options
         $send_via_job = $this->sendViaJob();
         $in = $this->getSendIn();// seconds
-        switch ($send_via_job) {
-            case 'yes':
-                return $this->queueAndSend($domain, $parameters, $in);
-            case 'when-attachments':
-                if (!empty($parameters['attachment'])) {
-                    return $this->queueAndSend($domain, $parameters, $in);
-                }
-                // fallback to direct
-                // no break
-            case 'no':
-            default:
-                return $client->messages()->send($domain, $parameters);
+        if ($send_via_job == 'yes') {
+            return $this->queueAndSend($domain, $parameters, $in);
+        } elseif ($send_via_job == 'when-attachments' && !empty($parameters['attachment'])) {
+            return $this->queueAndSend($domain, $parameters, $in);
+        } else {
+            return $client->messages()->send($domain, $parameters);
         }
-        return null;
     }
 
     /**