fix: Storybook builds by not running full loader on storybook virtua files #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 391 kB ℹ️ View Unchanged
|
ntucker
force-pushed
the
storybook-wyw-ignore
branch
from
2b46c04
to
5cc585e
Compare
ntucker
force-pushed
the
storybook-wyw-ignore
branch
from
5cc585e
to
9821042
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a workaround for Anber/wyw-in-js#30 wyw-in-js not being able to process some of the info.
https://github.com/storybookjs/storybook/blob/f013ffeb03377c6e1b76a9aabd94c180e3e3ef38/code/builders/builder-webpack5/src/preview/virtual-module-mapping.ts#L52 includes some storybook specific virtual files that are not compatible. However, these are not user files so there is no reason to run our loader processing on them - we can simply exclude those and let them fallback to how storybook rules work.
Solution
basePath