Skip to content

Commit

Permalink
disable tikv readonly (#1787)
Browse files Browse the repository at this point in the history
  • Loading branch information
vangheem authored Jan 30, 2024
1 parent 68db638 commit 02ed22d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions nucliadb/nucliadb/common/maindb/tikv.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ async def begin(
self, read_only: bool = False
) -> Union[TiKVTransaction, ReadOnlyTiKVTransaction]:
conn = self.get_connection_holder()
if read_only:
return ReadOnlyTiKVTransaction(await conn.get_snapshot(), self)
else:
return TiKVTransaction(await conn.begin_transaction(), self)
# if read_only:
# return ReadOnlyTiKVTransaction(await conn.get_snapshot(), self)
# else:
return TiKVTransaction(await conn.begin_transaction(), self)

3 comments on commit 02ed22d

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 02ed22d Previous: d4afd82 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 12994.80815941428 iter/sec (stddev: 1.832656669573226e-7) 13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 02ed22d Previous: d4afd82 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 12962.118275409774 iter/sec (stddev: 4.411230975699534e-8) 13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 02ed22d Previous: d4afd82 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 12847.004920144655 iter/sec (stddev: 8.112459078015207e-7) 13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.