Skip to content

Commit

Permalink
fix bump to not bump deps when on doing a semver change (#1694)
Browse files Browse the repository at this point in the history
  • Loading branch information
vangheem authored Dec 22, 2023
1 parent 0a5a6d7 commit 318ffd1
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 11 deletions.
4 changes: 4 additions & 0 deletions bump.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def run(args):
with open("VERSION", "w") as f:
f.write(python_version)

if args.sem:
# we only set other versions if we are not bumping a sem version
return

# replace node binding toml version as well
with open("nucliadb_node_binding/Cargo.toml", "r") as f:
cargo = f.read()
Expand Down
8 changes: 4 additions & 4 deletions nucliadb/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ aiodns>=3.0.0
types-orjson

# nucliadb dependencies are auto pinned on release
nucliadb-telemetry[all]>=2.37.0
nucliadb-utils[storages,fastapi,cache]>=2.37.0
nucliadb-protos>=2.37.0
nucliadb-models>=2.37.0
nucliadb-telemetry[all]
nucliadb-utils[storages,fastapi,cache]
nucliadb-protos
nucliadb-models
nucliadb-admin-assets>=1.0.0.post1224

asyncpg>=0.27.0
Expand Down
6 changes: 3 additions & 3 deletions nucliadb_dataset/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ types-google-cloud-ndb
types-boto3

# automatically bumped during release
nucliadb-protos>=2.37.0
nucliadb-sdk>=2.37.0
nucliadb-models>=2.37.0
nucliadb-protos
nucliadb-sdk
nucliadb-models
2 changes: 1 addition & 1 deletion nucliadb_models/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pydantic>=1.8.2,<2.0

# automatically bumped during release
nucliadb-protos>=2.37.0
nucliadb-protos
2 changes: 1 addition & 1 deletion nucliadb_sdk/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ orjson
pydantic>=1.10.9,<2.0

# automatically bumped during release
nucliadb-models>=2.37.0
nucliadb-models
4 changes: 2 additions & 2 deletions nucliadb_utils/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ memorylru>=1.1.2
mrflagly

# automatically bumped during release
nucliadb-protos>=2.37.0
nucliadb-telemetry>=2.37.0
nucliadb-protos
nucliadb-telemetry

1 comment on commit 318ffd1

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 318ffd1 Previous: 5a633b0 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 13317.30059460812 iter/sec (stddev: 1.2088245043270803e-7) 12745.686329086004 iter/sec (stddev: 1.7317806991721728e-7) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.