Skip to content

Commit

Permalink
pull zone from ZONE env var as well (#1783)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vangheem
vangheem authored Jan 29, 2024
1 parent 1f3d8b1 commit 56e1386
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nucliadb_telemetry/nucliadb_telemetry/errors.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def push_scope(**kwargs: Any) -> ContextManager[Scope]:


class ErrorHandlingSettings(BaseSettings):
zone: str = pydantic.Field(default="local", env=["NUCLIA_ZONE"])
zone: str = pydantic.Field(default="local", env=["NUCLIA_ZONE", "ZONE"])
sentry_url: Optional[str] = None
environment: str = pydantic.Field(
default="local", env=["environment", "running_environment"]
Expand Down

3 comments on commit 56e1386

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 56e1386 Previous: d4afd82 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 12930.799432071937 iter/sec (stddev: 6.519714643633313e-7) 13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 56e1386 Previous: d4afd82 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 13253.039273465734 iter/sec (stddev: 0.0000010484641640349511) 13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 56e1386 Previous: d4afd82 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 13044.801290855006 iter/sec (stddev: 4.770783102185965e-7) 13028.533525895236 iter/sec (stddev: 4.192637045977425e-7) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.