Upgrade to Python 3.11 (#1246)

* Passing corountines to wait is now forbidden * Remove unused pytestmark * Upgrade workflows to lint 3.9-11 and test with 3.11 * Quote Python versions * Quote 3.11's * Upgrade docker images to Python 3.11 * Update setup.py's with dropping 3.8 * Upgrade install-vm script to Python 3.11
nuclia · Aug 23, 2023 · 6dd34be · 6dd34be · github-actions · Aug 23, 2023
1 parent cc10aa3
commit 6dd34be
Show file tree

Hide file tree

Showing 33 changed files with 97 additions and 71 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -72,7 +72,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v4
         with:
-          python-version: 3.9
+          python-version: 3.11
           cache: "pip"
 
       - name: Install test deps

diff --git a/.github/workflows/nucliadb.yml b/.github/workflows/nucliadb.yml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -49,7 +49,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_client.yml b/.github/workflows/nucliadb_client.yml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -43,7 +43,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_dataset.yml b/.github/workflows/nucliadb_dataset.yml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -43,7 +43,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_ingest.yml b/.github/workflows/nucliadb_ingest.yml
@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -47,7 +47,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_models.yml b/.github/workflows/nucliadb_models.yml
@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_node.yml b/.github/workflows/nucliadb_node.yml
@@ -62,7 +62,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -171,7 +171,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_node_binding.yml b/.github/workflows/nucliadb_node_binding.yml
@@ -18,7 +18,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_node_release.yml b/.github/workflows/nucliadb_node_release.yml
@@ -76,7 +76,7 @@ jobs:
       - name: set up python
         uses: actions/setup-python@v4
         with:
-          python-version: "3.10"
+          python-version: "3.11"
           architecture: ${{ matrix.python-architecture || 'x64' }}
 
       - run: pip install -U twine 'black>=22.3.0,<23' typing_extensions
@@ -134,7 +134,7 @@ jobs:
       - name: set up python
         uses: actions/setup-python@v4
         with:
-          python-version: "3.10"
+          python-version: "3.11"
 
       - run: pip install -U twine
 

diff --git a/.github/workflows/nucliadb_reader.yml b/.github/workflows/nucliadb_reader.yml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -48,7 +48,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_sdk.yml b/.github/workflows/nucliadb_sdk.yml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -43,7 +43,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_search.yml b/.github/workflows/nucliadb_search.yml
@@ -51,7 +51,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -75,7 +75,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_standalone.yml b/.github/workflows/nucliadb_standalone.yml
@@ -41,7 +41,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -65,7 +65,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_telemetry.yml b/.github/workflows/nucliadb_telemetry.yml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -50,7 +50,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_telemetry_release.yml b/.github/workflows/nucliadb_telemetry_release.yml
@@ -21,7 +21,7 @@ jobs:
 
       - uses: actions/setup-python@v4
         with:
-          python-version: 3.9
+          python-version: 3.11
 
       - name: Install requirements
         run: |

diff --git a/.github/workflows/nucliadb_train.yml b/.github/workflows/nucliadb_train.yml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -48,7 +48,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_utils.yml b/.github/workflows/nucliadb_utils.yml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -43,7 +43,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/nucliadb_writer.yml b/.github/workflows/nucliadb_writer.yml
@@ -24,7 +24,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.9", "3.10", "3.11"]
 
     steps:
       - name: Checkout the repository
@@ -48,7 +48,7 @@ jobs:
 
     strategy:
       matrix:
-        python-version: [3.9]
+        python-version: ["3.11"]
 
     steps:
       - name: Checkout the repository

diff --git a/.github/workflows/pypi_release.yml b/.github/workflows/pypi_release.yml
@@ -15,7 +15,7 @@ jobs:
 
       - uses: actions/setup-python@v4
         with:
-          python-version: 3.9
+          python-version: 3.11
 
       - name: Setup env
         run: |
@@ -42,42 +42,42 @@ jobs:
         uses: lewagon/[email protected]
         with:
           ref: main
-          check-name: NucliaDBUtilsTests (3.9)
+          check-name: NucliaDBUtilsTests (3.11)
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           wait-interval: 10
       - name: Wait for models
         uses: lewagon/[email protected]
         with:
           ref: main
-          check-name: NucliaDBModelsTests (3.9)
+          check-name: NucliaDBModelsTests (3.11)
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           wait-interval: 10
       - name: Wait for client tests
         uses: lewagon/[email protected]
         with:
           ref: main
-          check-name: NucliaDBClientTests (3.9)
+          check-name: NucliaDBClientTests (3.11)
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           wait-interval: 10
       - name: Wait for sdk tests
         uses: lewagon/[email protected]
         with:
           ref: main
-          check-name: NucliaDBSDKTests (3.9)
+          check-name: NucliaDBSDKTests (3.11)
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           wait-interval: 10
       - name: Wait for dataset tests
         uses: lewagon/[email protected]
         with:
           ref: main
-          check-name: NucliaDBDatasetTests (3.9)
+          check-name: NucliaDBDatasetTests (3.11)
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           wait-interval: 10
       - name: Wait for nucliadb tests
         uses: lewagon/[email protected]
         with:
           ref: main
-          check-name: NucliaDBTests (3.9)
+          check-name: NucliaDBTests (3.11)
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           wait-interval: 10
 

diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM python:3.9
+FROM python:3.11
 
 WORKDIR /usr/src/app
 

diff --git a/Dockerfile.node_sidecar b/Dockerfile.node_sidecar
@@ -1,4 +1,4 @@
-FROM python:3.9 AS builder
+FROM python:3.11 AS builder
 
 RUN mkdir -p /usr/src/app
 

diff --git a/Dockerfile.rust b/Dockerfile.rust
@@ -1,4 +1,4 @@
-FROM python:3.9 as python_rust
+FROM python:3.11 as python_rust
 
 ENV RUSTUP_HOME=/usr/local/rustup \
     CARGO_HOME=/usr/local/cargo \

diff --git a/Dockerfile.withbinding b/Dockerfile.withbinding
@@ -1,4 +1,4 @@
-FROM python:3.9 as python_rust
+FROM python:3.11 as python_rust
 
 ARG RUST_BUILD_PROFILE=release
 
@@ -39,7 +39,7 @@ RUN set -eux; \
     maturin build --profile ${RUST_BUILD_PROFILE}
 
 
-FROM python:3.9
+FROM python:3.11
 ENV TIKV_CLIENT_VERSION=0.0.3
Benchmark suite	Current: `6dd34be`	Previous: `a40981d`	Ratio
`nucliadb/tests/benchmarks/test_search.py::test_search_returns_labels`	`60.968364451013414` iter/sec (`stddev: 0.0007288368999887676`)	`60.779932309336715` iter/sec (`stddev: 0.0019119907918232523`)	`1.00`
`nucliadb/tests/benchmarks/test_search.py::test_search_relations`	`154.0769321858245` iter/sec (`stddev: 0.00022233477779594728`)	`182.57436721258293` iter/sec (`stddev: 0.0002220745559283828`)	`1.18`