Unpin and update uvicorn version (#2514)

* Unpin and update uvicorn version

* Unrelated format

* Update fixes

nucliadb/requirements.txt

@@ -7,7 +7,7 @@ nucliadb-admin-assets>=1.0.0.post1224
 nucliadb-node-binding>=2.26.0
 
 # external dependencies
-uvicorn<0.19.0
+uvicorn
 argdantic
 
 aiohttp>=3.9.4

nucliadb_telemetry/src/nucliadb_telemetry/logs.py

@@ -41,9 +41,9 @@
 from . import context
 
 try:
-    from uvicorn.logging import AccessFormatter  # type: ignore
+    from uvicorn.logging import AccessFormatter
 except ImportError:  # pragma: no cover
-    AccessFormatter = logging.Formatter
+    AccessFormatter = logging.Formatter  # type: ignore
 
 _BUILTIN_ATTRS = set(
     [

nucliadb_utils/requirements-fastapi.txt

@@ -1,3 +1,3 @@
 fastapi>=0.95.2
-uvicorn>=0.16.0,<0.19.0
 starlette>=0.21.0
+uvicorn

nucliadb_utils/src/nucliadb_utils/fastapi/run.py

@@ -20,6 +20,7 @@
 import asyncio
 import os
 import sys
+from contextlib import AbstractContextManager, nullcontext
 
 import click
 from fastapi import FastAPI
@@ -34,14 +35,11 @@
 
 
 def metrics_app() -> tuple[Server, Config]:
-    loop_setup = "auto"
-
     metrics_config = Config(
         application_metrics,
         host=running_settings.metrics_host,
         port=running_settings.metrics_port,
-        debug=False,
-        loop=loop_setup,
+        loop="auto",
         http="auto",
         reload=False,
         workers=1,
@@ -63,14 +61,12 @@ async def serve_metrics() -> Server:
 
 
 def run_fastapi_with_metrics(application: FastAPI) -> None:
-    loop_setup = "auto"
     metrics_server, metrics_config = metrics_app()
     config = Config(
         application,
         host=running_settings.serving_host,
         port=running_settings.serving_port,
-        debug=running_settings.debug,
-        loop=loop_setup,
+        loop="auto",
         http="auto",
         reload=False,
         workers=1,
@@ -113,14 +109,22 @@ async def run_server_forever(server: Server, config: Config):
     await start_server(server, config)
     process_id = os.getpid()
 
-    server.install_signal_handlers()
-
-    message = "Started server process [%d]"
-    color_message = "Started server process [" + click.style("%d", fg="cyan") + "]"
-    logger.info(message, process_id, extra={"color_message": color_message})
-
-    if server.should_exit:
-        return
-
-    await server.main_loop()
-    await server.shutdown()
+    # compatibility with uvicorn<0.29
+    capture_signals: AbstractContextManager
+    if hasattr(server, "install_signal_handlers"):  # pragma: no cover
+        server.install_signal_handlers()
+        capture_signals = nullcontext()
+    else:
+        # uvicorn>=0.29
+        capture_signals = server.capture_signals()
+
+    with capture_signals:
+        message = "Started server process [%d]"
+        color_message = "Started server process [" + click.style("%d", fg="cyan") + "]"
+        logger.info(message, process_id, extra={"color_message": color_message})
+
+        if server.should_exit:
+            return
+
+        await server.main_loop()
+        await server.shutdown()