Skip to content

Commit

Permalink
Update GHA to Ubuntu 24 (#2614)
Browse files Browse the repository at this point in the history
  • Loading branch information
javitonino authored Nov 8, 2024
1 parent 73f215d commit 9fab332
Show file tree
Hide file tree
Showing 9 changed files with 39 additions and 39 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/_build-img-nucliadb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ env:
jobs:
build-img:
name: Build image
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
outputs:
imageid: ${{ steps.build-image.outputs.imageid }}
digest: ${{ steps.build-image.outputs.digest }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/bump-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:

jobs:
bump:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout repository
Expand All @@ -33,8 +33,8 @@ jobs:

- uses: actions/checkout@master
with:
persist-credentials: false
fetch-depth: 0
persist-credentials: false
fetch-depth: 0

- run: python bump.py --sem=${{ inputs.semType }}

Expand Down
38 changes: 19 additions & 19 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ jobs:
# Pre-checks
format-rust:
name: "Pre-checks: Rust code Format"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: rustfmt
run: cargo fmt --check

clippy-rust:
name: "Pre-checks: Clippy lint"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- run: rustup component add clippy
Expand All @@ -36,15 +36,15 @@ jobs:

nidx-format-rust:
name: "nidx: Rust code Format"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: rustfmt
run: cd nidx && cargo fmt --check

nidx-clippy-rust:
name: "nidx: Clippy lint"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- run: rustup component add clippy
Expand All @@ -58,7 +58,7 @@ jobs:

updated-protos:
name: "Pre-checks: Protos up-to-date"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions: write-all
needs:
- build-virtual-env
Expand All @@ -82,7 +82,7 @@ jobs:

pre-checks-python:
name: "Pre-checks: Python lint"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-virtual-env
steps:
Expand All @@ -108,7 +108,7 @@ jobs:
lint-helm:
name: Lint all helm charts
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout repository
Expand All @@ -126,7 +126,7 @@ jobs:
check-licenses:
name: Check Licenses
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: Check License Header
Expand All @@ -140,7 +140,7 @@ jobs:
command: check licenses

check-migrations:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-virtual-env
steps:
Expand All @@ -161,7 +161,7 @@ jobs:
# Builds
build-node-binaries:
name: Build node binaries
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
Expand All @@ -175,7 +175,7 @@ jobs:

build-virtual-env:
name: Build virtual environment
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
Expand All @@ -195,7 +195,7 @@ jobs:
# Tests
sidecar-tests:
name: Sidecar tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-node-binaries
- build-virtual-env
Expand Down Expand Up @@ -234,7 +234,7 @@ jobs:

nucliadb-search-tests:
name: NucliaDB search tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-node-binaries
- build-virtual-env
Expand Down Expand Up @@ -276,7 +276,7 @@ jobs:

node-rust-tests:
name: Node Rust tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: Swatinem/rust-cache@v2
Expand All @@ -285,7 +285,7 @@ jobs:

nidx-tests:
name: nidx tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
services:
postgres:
image: postgres:15
Expand Down Expand Up @@ -313,7 +313,7 @@ jobs:

nucliadb-tests:
name: NucliaDB tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-virtual-env
strategy:
Expand Down Expand Up @@ -359,7 +359,7 @@ jobs:

nucliadb-components-tests:
name: NucliaDB components tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-virtual-env
strategy:
Expand Down Expand Up @@ -401,7 +401,7 @@ jobs:

python-packages-tests:
name: Python packages tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-virtual-env
strategy:
Expand Down Expand Up @@ -445,7 +445,7 @@ jobs:
# Depends on all tests to pass
ci-passed:
name: CI passed
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- format-rust
- clippy-rust
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
jobs:
build-node-image:
name: Build node image
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:

upload-chart-nucliadb-shared:
name: Deploy nucliadb shared
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Generate a token
id: app-token
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
upload-chart-nucliadb-node:
name: Upload Node chart
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs:
- build-python-images
- build-node-image
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
upload-charts-nucliadb-component:
name: Upload NucliaDB component charts
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
outputs:
version_number: ${{ steps.version_step.outputs.version_number }}
needs:
Expand Down Expand Up @@ -283,7 +283,7 @@ jobs:
upload-chart-nidx:
name: Upload nidx chart
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: inputs.environment == 'dev'
needs:
- build-nidx-image
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
deploy-nucliadb-components:
name: Deploy NucliaDB components
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: ${{ !failure() && !cancelled() }}
needs:
- upload-chart-nucliadb-shared
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
# Chart configuration: e2e/conf/chart.values.yaml
#
name: E2E Kubernetes Cluster Tests
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout code
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nucliadb_node_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
list-pypi-files:
needs: [build]
if: github.event_name == 'push'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand All @@ -135,7 +135,7 @@ jobs:

release:
needs: [build]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.event_name == 'push'

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/public_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
jobs:
release:
name: Tag and release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout repository
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:

tag-stable:
name: Tag current latest as stable
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.event_name == 'push'

steps:
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
docs:
name: 'Upload API specs'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.event_name == 'push'

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions:
jobs:
build_wheels:
name: Build wheels
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Generate a token
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:

push-docker:
name: Build and push nucliadb docker image
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:

deploy:
name: Deploy Helm chart and trigger internal CI
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: push-docker

steps:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.node_prebuilt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# For a version that compiles the binaries inside docker, see `Dockerfile.node`
#

FROM debian:bookworm-slim
FROM ubuntu:24.04

ENV DATA_PATH=data
ENV RUST_LOG=nucliadb_node=DEBUG
Expand Down

0 comments on commit 9fab332

Please sign in to comment.