Run all pre-checks in a single job

nuclia · Jun 6, 2024 · b195d9f · b195d9f
1 parent 7805700
commit b195d9f
Show file tree

Hide file tree

Showing 45 changed files with 51 additions and 548 deletions.
diff --git a/.github/workflows/_component_prechecks.yml b/.github/workflows/_component_prechecks.yml
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -62,31 +62,7 @@ jobs:
         run: git status && [[ -z "$(git status -s)" ]]
 
   pre-checks-python:
-    name: "Pre-checks: Node python lint"
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-
-      - name: Run pre-checks
-        run: |
-          pip install -r code-requirements.txt
-          isort -c --profile black nucliadb_sidecar
-          cd nucliadb_sidecar
-          flake8 src/nucliadb_sidecar --config=setup.cfg
-          black --check .
-
-  mypy-check:
-    name: "Pre-checks: Node mypy"
+    name: "Pre-checks: Python lint"
     runs-on: ubuntu-latest
     needs:
       - build-virtual-env
@@ -103,7 +79,13 @@ jobs:
           key: venv-${{ github.sha }}
           fail-on-cache-miss: true
       - name: Run mypy
-        run: pdm run mypy nucliadb_sidecar
+        run: |
+          source .venv/bin/activate
+          for package in nucliadb nucliadb_utils nucliadb_telemetry nucliadb_sdk nucliadb_dataset nucliadb_models nucliadb_sidecar nucliadb_node_binding nucliadb_performance
+          do
+              make -C $package lint || ERROR=1
+          done
+          exit $ERROR
 
   licenses:
     name: Check Licenses

diff --git a/.github/workflows/nucliadb.yml b/.github/workflows/nucliadb.yml
@@ -23,12 +23,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  pre-checks:
-    uses: ./.github/workflows/_component_prechecks.yml
-    with:
-      component: "nucliadb"
-      python_version: "3.12"
-
   # Job to run Python tests
   tests:
     name: NucliaDBTests

diff --git a/.github/workflows/nucliadb_dataset.yml b/.github/workflows/nucliadb_dataset.yml
@@ -13,15 +13,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  pre-checks:
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-    uses: ./.github/workflows/_component_prechecks.yml
-    with:
-      python_version: "${{ matrix.python-version }}"
-      component: "nucliadb_dataset"
-
   # Job to run tests
   tests:
     name: NucliaDBDatasetTests

diff --git a/.github/workflows/nucliadb_ingest.yml b/.github/workflows/nucliadb_ingest.yml
@@ -18,29 +18,6 @@ env:
   TESTING_TIKV_LOCAL: "true"
 
 jobs:
-  # Job to run pre-checks
-  pre-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-          cache: "pip"
-
-      - name: Install package
-        run: make -C nucliadb/ install-dev
-
-      - name: Run pre-checks
-        run: make -C nucliadb/ lint
-
   # Job to run tests
   tests:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/nucliadb_models.yml b/.github/workflows/nucliadb_models.yml
diff --git a/.github/workflows/nucliadb_node.yml b/.github/workflows/nucliadb_node.yml
@@ -69,39 +69,6 @@ env:
   GCP_SERVICE_ACCOUNT: "[email protected]"
 
 jobs:
-  pre-checks-python:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-          cache: "pip"
-
-      - name: Install package
-        run: make -C nucliadb_sidecar/ install-dev
-
-      - name: Run pre-checks
-        run: make -C nucliadb_sidecar/ lint
-
-  licenses:
-    name: Check Licenses
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: EmbarkStudios/cargo-deny-action@v1
-        name: cargo deny
-        with:
-          log-level: warn
-          command: check licenses
-
   format-rust:
     name: Rust code Format
     runs-on: ubuntu-latest
@@ -168,7 +135,6 @@ jobs:
   tests-python:
     name: Python tests
     runs-on: ubuntu-latest
-    needs: [pre-checks-python, licenses]
 
     strategy:
       matrix:

diff --git a/.github/workflows/nucliadb_reader.yml b/.github/workflows/nucliadb_reader.yml
@@ -17,29 +17,6 @@ env:
   IMAGE_NAME: reader
 
 jobs:
-  # Job to run pre-checks
-  pre-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ['3.9', '3.12']
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-          cache: 'pip'
-
-      - name: Install package
-        run: make -C nucliadb/ install-dev
-
-      - name: Run pre-checks
-        run: make -C nucliadb/ lint-reader
-
   # Job to run tests
   tests:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/nucliadb_sdk.yml b/.github/workflows/nucliadb_sdk.yml
@@ -13,15 +13,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  pre-checks:
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-    uses: ./.github/workflows/_component_prechecks.yml
-    with:
-      python_version: "${{ matrix.python-version }}"
-      component: "nucliadb_sdk"
-
   # Job to run tests
   tests:
     name: NucliaDBSDKTests

diff --git a/.github/workflows/nucliadb_search.yml b/.github/workflows/nucliadb_search.yml
@@ -53,29 +53,6 @@ env:
   GCP_SERVICE_ACCOUNT: "[email protected]"
 
 jobs:
-  # Job to run pre-checks
-  pre-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ['3.9', '3.10', '3.12']
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-          cache: 'pip'
-
-      - name: Install package
-        run: make -C nucliadb/ install-dev
-
-      - name: Run pre-checks
-        run: make -C nucliadb/ lint-search
-
   # Job to run tests
   tests:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/nucliadb_standalone.yml b/.github/workflows/nucliadb_standalone.yml
@@ -47,29 +47,6 @@ permissions:
   contents: read    # This is required for actions/checkout
 
 jobs:
-  # Job to run pre-checks
-  pre-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-          cache: "pip"
-
-      - name: Install package
-        run: make -C nucliadb/ install-dev
-
-      - name: Run pre-checks
-        run: make -C nucliadb/ lint-standalone
-
   # Job to run tests
   tests:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/nucliadb_telemetry.yml b/.github/workflows/nucliadb_telemetry.yml
@@ -19,15 +19,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  pre-checks:
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-    uses: ./.github/workflows/_component_prechecks.yml
-    with:
-      python_version: "${{ matrix.python-version }}"
-      component: "nucliadb_telemetry"
-
   # Job to run tests
   tests:
     name: NucliaDBTelemetryTests

diff --git a/.github/workflows/nucliadb_train.yml b/.github/workflows/nucliadb_train.yml
@@ -18,29 +18,6 @@ env:
   IMAGE_NAME: nucliadb_train
 
 jobs:
-  # Job to run pre-checks
-  pre-checks:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-
-    steps:
-      - name: Checkout the repository
-        uses: actions/checkout@v3
-
-      - name: Setup Python
-        uses: actions/setup-python@v4
-        with:
-          python-version: ${{ matrix.python-version }}
-          cache: "pip"
-
-      - name: Install package
-        run: make -C nucliadb/ install-dev
-
-      - name: Run pre-checks
-        run: make -C nucliadb/ lint-train
-
   # Job to run tests
   tests:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/nucliadb_utils.yml b/.github/workflows/nucliadb_utils.yml
@@ -13,16 +13,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  # Job to run pre-checks
-  pre-checks:
-    strategy:
-      matrix:
-        python-version: ["3.9", "3.12"]
-    uses: ./.github/workflows/_component_prechecks.yml
-    with:
-      python_version: "${{ matrix.python-version }}"
-      component: "nucliadb_utils"
-
   # Job to run tests
   tests:
     name: NucliaDBUtilsTests