move nucliadb_node/binding to the root [sc-6670]
#1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 85.01% 85.01%
=======================================
Files 402 402
Lines 22314 22314
=======================================
Hits 18971 18971
Misses 3343 3343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tarekziade
force-pushed
the
tarekziade/refactor-nucliadb-node-binding
branch
from
b57c562
to
82968ec
Compare
hermeGarcia
approved these changes
Aug 2, 2023
tarekziade
changed the title
nucliadb_node/binding to the rootnucliadb_node/binding to the root [sc-6670]
tarekziade
force-pushed
the
tarekziade/refactor-nucliadb-node-binding
branch
from
bbb2bb2
to
5e62579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move the
nucliadb-node-bindingpackage as a root packageHow was this PR tested?
The
nucliadb_nodeGH action and the Makefile were adapted to pick the binding in the right spot.