-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thread dump service rust #1270
thread dump service rust #1270
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 412 412
Lines 22811 22811
=======================================
Hits 19396 19396
Misses 3415 3415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 840 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
727 | 1 | 112 | 0 |
Click to see the invalid file list
- nucliadb_node/pyproject.toml
e9bb625
to
972f09d
Compare
/bench |
Benchmarks comparison to main branch
Happy hacking! |
/bench |
Benchmarks comparison to main branch
Happy hacking! |
4eca9ff
to
dbc6fbb
Compare
nucliadb_node/src/http_server/mod.rs
Outdated
@@ -33,13 +34,13 @@ pub struct MetricsServerOptions { | |||
pub default_http_port: u16, | |||
} | |||
|
|||
pub async fn run_http_metrics_server(options: MetricsServerOptions) { | |||
pub async fn run_http_server(options: MetricsServerOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: you could also rename MetricsServerOptions
to ServerOptions
for example, as the function is now more generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
f6a304a
to
88848ba
Compare
Description
Adds the
/__dump
endpoint to the rust HTTP service to help debugging.How was this PR tested?
Describe how you tested this PR.