Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref merge core #1604

Merged
merged 9 commits into from
Nov 28, 2023
Merged

ref merge core #1604

merged 9 commits into from
Nov 28, 2023

Conversation

hermeGarcia
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@hermeGarcia hermeGarcia requested a review from a team as a code owner November 23, 2023 10:35
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9648a2) 81.16% compared to head (d45e5e8) 81.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1604   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         319      319           
  Lines       18994    18994           
=======================================
  Hits        15416    15416           
  Misses       3578     3578           
Flag Coverage Δ
ingest 69.18% <ø> (ø)
node-sidecar 91.98% <ø> (ø)
nucliadb 69.85% <ø> (ø)
reader 77.09% <ø> (ø)
sdk 42.88% <ø> (ø)
search 76.89% <ø> (+0.04%) ⬆️
standalone 82.94% <ø> (ø)
train 60.77% <ø> (ø)
utils 80.55% <ø> (ø)
writer 85.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hermeGarcia hermeGarcia force-pushed the merge-clean branch 2 times, most recently from a2a3db8 to 6aacd06 Compare November 27, 2023 09:37
@hermeGarcia hermeGarcia added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit eb802a8 Nov 28, 2023
96 checks passed
@hermeGarcia hermeGarcia deleted the merge-clean branch November 28, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants