Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create S3 bucket with tags #1608

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Create S3 bucket with tags #1608

merged 4 commits into from
Nov 27, 2023

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Nov 27, 2023

Description

We need KB buckets on s3 to have a predefined set of tags (via configuration)

How was this PR tested?

Extended existing tests

@lferran lferran requested a review from a team as a code owner November 27, 2023 09:44
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bc97f8f) 81.08% compared to head (0417877) 81.10%.
Report is 1 commits behind head on main.

Files Patch % Lines
nucliadb_utils/nucliadb_utils/storages/s3.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   81.08%   81.10%   +0.01%     
==========================================
  Files         323      323              
  Lines       19060    19059       -1     
==========================================
+ Hits        15455    15457       +2     
+ Misses       3605     3602       -3     
Flag Coverage Δ
ingest 69.18% <ø> (ø)
nucliadb 69.85% <33.33%> (+0.05%) ⬆️
reader 77.09% <ø> (ø)
sdk 42.88% <ø> (ø)
search 76.85% <ø> (-0.03%) ⬇️
standalone 82.94% <ø> (ø)
train 60.77% <ø> (ø)
utils 80.55% <90.90%> (+0.12%) ⬆️
writer 85.35% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 2f2bf39 Nov 27, 2023
76 checks passed
@lferran lferran deleted the s3-bucket-labels branch November 27, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants