Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix using auto bump versions in docker release #1614

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix using auto bump versions in docker release #1614

merged 1 commit into from
Nov 28, 2023

Conversation

vangheem
Copy link
Contributor

Description

We can not mix build numbers that we use for -post version numbers so this should be in single workflow

How was this PR tested?

Describe how you tested this PR.

@vangheem vangheem requested a review from a team as a code owner November 27, 2023 21:54
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2e7c10) 81.16% compared to head (a67d3f8) 81.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1614   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         319      319           
  Lines       18994    18994           
=======================================
  Hits        15416    15416           
  Misses       3578     3578           
Flag Coverage Δ
ingest 69.18% <ø> (ø)
nucliadb 69.85% <ø> (ø)
reader 77.09% <ø> (ø)
sdk 42.88% <ø> (ø)
train 60.77% <ø> (ø)
utils 80.55% <ø> (ø)
writer 85.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit f9648a2 Nov 28, 2023
65 checks passed
@jotare jotare deleted the fix-release-gh branch November 28, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants