Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shards in stable channel use relations v2 #1679

Merged

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Dec 19, 2023

Description

Make new shards use relations v2 in both release channels (stable and experimental)

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team as a code owner December 19, 2023 12:14
Copy link

This pull request has been linked to Shortcut Story #8056: Move relations v2 to STABLE.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61f72f4) 81.85% compared to head (2323024) 81.98%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
+ Coverage   81.85%   81.98%   +0.13%     
==========================================
  Files         332      332              
  Lines       19303    19309       +6     
==========================================
+ Hits        15800    15831      +31     
+ Misses       3503     3478      -25     
Flag Coverage Δ
ingest 69.25% <ø> (ø)
node-sidecar 95.62% <ø> (+1.61%) ⬆️
nucliadb 70.60% <ø> (-0.02%) ⬇️
reader 76.90% <ø> (ø)
sdk 40.46% <ø> (ø)
search 79.24% <ø> (ø)
standalone 85.68% <ø> (+4.27%) ⬆️
train 63.33% <ø> (ø)
utils 81.24% <ø> (ø)
writer 85.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare force-pushed the joanantoniriera4168/sc-8056/move-relations-v2-to-stable branch from 6fa5b37 to cb58db7 Compare December 19, 2023 16:59
@jotare jotare force-pushed the joanantoniriera4168/sc-8056/move-relations-v2-to-stable branch from cb58db7 to 1843ace Compare December 21, 2023 11:35
@jotare jotare merged commit 43ea441 into main Jan 3, 2024
105 checks passed
@jotare jotare deleted the joanantoniriera4168/sc-8056/move-relations-v2-to-stable branch January 3, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants