Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf job: send if node modified to build bindings conditionally #1701

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jan 3, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b1a066) 82.04% compared to head (4921fc2) 82.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   82.04%   82.07%   +0.03%     
==========================================
  Files         333      333              
  Lines       19400    19400              
==========================================
+ Hits        15916    15923       +7     
+ Misses       3484     3477       -7     
Flag Coverage Δ
ingest 69.25% <ø> (ø)
node-sidecar 95.62% <ø> (+1.61%) ⬆️
nucliadb 70.38% <ø> (ø)
reader 76.90% <ø> (ø)
sdk 40.46% <ø> (ø)
train 63.33% <ø> (ø)
utils 81.24% <ø> (ø)
writer 85.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran force-pushed the perf-install-bindings-locally2 branch from 8294498 to 4921fc2 Compare January 3, 2024 13:03
@lferran lferran requested a review from a team January 3, 2024 13:22
@lferran lferran merged commit 8ad4b5e into main Jan 3, 2024
93 checks passed
@lferran lferran deleted the perf-install-bindings-locally2 branch January 3, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants