Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing v2 integration #1719

Merged
merged 15 commits into from
Jan 20, 2024
Merged

Processing v2 integration #1719

merged 15 commits into from
Jan 20, 2024

Conversation

vangheem
Copy link
Contributor

@vangheem vangheem commented Jan 11, 2024

Description

Support for v2 of the processing api enabled by using processing_v2 env var.

Right now, only activate by specifying the

How was this PR tested?

Describe how you tested this PR.

@vangheem vangheem marked this pull request as draft January 11, 2024 21:53
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (c3f6c03) 82.20% compared to head (46290ae) 82.11%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ucliadb/nucliadb/common/http_clients/processing.py 34.37% 21 Missing ⚠️
nucliadb/nucliadb/reader/api/v1/services.py 55.55% 4 Missing ⚠️
nucliadb/nucliadb/writer/api/v1/field.py 88.23% 2 Missing ⚠️
nucliadb/nucliadb/writer/api/v1/upload.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   82.20%   82.11%   -0.09%     
==========================================
  Files         336      336              
  Lines       19609    19662      +53     
==========================================
+ Hits        16119    16146      +27     
- Misses       3490     3516      +26     
Flag Coverage Δ
ingest 69.07% <100.00%> (+0.02%) ⬆️
nucliadb 70.26% <54.79%> (-0.09%) ⬇️
reader 79.05% <55.55%> (-0.36%) ⬇️
sdk 40.58% <ø> (ø)
search 79.04% <ø> (ø)
standalone 88.29% <ø> (ø)
train 63.71% <ø> (ø)
utils 81.42% <100.00%> (+0.17%) ⬆️
writer 85.15% <86.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem changed the title WIP: processing v2 integration Processing v2 integration Jan 16, 2024
@vangheem vangheem marked this pull request as ready for review January 16, 2024 21:19
Copy link
Contributor

@lferran lferran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments"

nucliadb/nucliadb/common/http_clients/processing.py Outdated Show resolved Hide resolved
nucliadb/nucliadb/common/http_clients/processing.py Outdated Show resolved Hide resolved
nucliadb/nucliadb/ingest/consumer/pull_v2.py Outdated Show resolved Hide resolved
nucliadb/nucliadb/ingest/consumer/pull_v2.py Outdated Show resolved Hide resolved
nucliadb/nucliadb/ingest/consumer/pull_v2.py Outdated Show resolved Hide resolved
nucliadb/nucliadb/ingest/consumer/pull_v2.py Outdated Show resolved Hide resolved
nucliadb/nucliadb/writer/api/v1/upload.py Show resolved Hide resolved
nucliadb/nucliadb/writer/resource/basic.py Outdated Show resolved Hide resolved
@vangheem vangheem merged commit 474a5a7 into main Jan 20, 2024
83 checks passed
@vangheem vangheem deleted the processing-v2 branch January 20, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants