Use monotonic timers for metrics #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javitonino
force-pushed
the
monotonic-timers
branch
from
1ccc8bd
to
0157ec5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
=======================================
Coverage 82.19% 82.20%
=======================================
Files 335 336 +1
Lines 19592 19609 +17
=======================================
+ Hits 16104 16119 +15
- Misses 3488 3490 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hermeGarcia
reviewed
Jan 18, 2024
nucliadb_texts2/src/writer.rs
Outdated
| debug!("{id:?} - Indexing document: starts at {v} ms"); | ||
| } | ||
| let v = time.elapsed().as_millis(); | ||
| debug!("{id:?} - Indexing document: starts at {v} ms"); |
There was a problem hiding this comment.
Should say "ends" not "starts", was already wrong before.
hermeGarcia
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of metrics were using
SystemTimewhen it's more appropriate to useInstantfor measuring elapsed time. This PR changes all of those to useInstant.It does not change it in some places where it was persisted to disk and compared across executions.
Of particular note: https://github.com/nuclia/nucliadb/compare/monotonic-timers?expand=1#diff-9da5113fe7de5eb5858d773e4e90b81a2f8abeaff96517361fd3e2f3c9cc8fb4L352 which could panic the replication process when measuring time across a time-discontinuity (usually due to a NTP clock adjustment).
This PR might just be the results of a regex search/replace and some manual review. 🙄
How was this PR tested?
Describe how you tested this PR.