Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose title for processing status results #1769

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

vangheem
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4dc7501) 82.11% compared to head (a540bf6) 82.13%.

Files Patch % Lines
nucliadb/nucliadb/reader/api/v1/services.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
+ Coverage   82.11%   82.13%   +0.01%     
==========================================
  Files         335      335              
  Lines       19677    19682       +5     
==========================================
+ Hits        16158    16166       +8     
+ Misses       3519     3516       -3     
Flag Coverage Δ
ingest 69.06% <ø> (ø)
nucliadb 70.13% <23.80%> (-0.08%) ⬇️
reader 79.82% <90.47%> (+0.76%) ⬆️
sdk 40.64% <ø> (ø)
search 78.95% <ø> (ø)
standalone 88.29% <ø> (ø)
train 63.60% <ø> (ø)
utils 81.42% <ø> (ø)
writer 85.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem merged commit 417c9b4 into main Jan 24, 2024
81 checks passed
@vangheem vangheem deleted the compose-title-proc-status branch January 24, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants