Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

box readers + swap update #2122

Merged
merged 1 commit into from
May 7, 2024
Merged

box readers + swap update #2122

merged 1 commit into from
May 7, 2024

Conversation

hermeGarcia
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link
Contributor

@jotare jotare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 91e93b8 Previous: 1a9ce6c Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 13272.981082906274 iter/sec (stddev: 2.860400016902787e-7) 13339.058637295573 iter/sec (stddev: 1.296413027597777e-7) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@hermeGarcia hermeGarcia merged commit e9a546a into main May 7, 2024
94 checks passed
@hermeGarcia hermeGarcia deleted the reader-swap-update branch May 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants