Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete vectors on label change #2211

Merged
merged 12 commits into from
Jun 3, 2024
Merged

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 754be1a Previous: 08db1e8 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 3024.5924667866993 iter/sec (stddev: 0.000002289492274452081) 3041.132211072051 iter/sec (stddev: 0.0000011628635974660105) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (b551226) to head (4f36765).

Current head 4f36765 differs from pull request most recent head 754be1a

Please upload reports for the commit 754be1a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2211      +/-   ##
==========================================
+ Coverage   77.15%   85.18%   +8.03%     
==========================================
  Files          94        4      -90     
  Lines        6045      162    -5883     
==========================================
- Hits         4664      138    -4526     
+ Misses       1381       24    -1357     
Flag Coverage Δ
ingest ?
node-sidecar ?
sdk 85.18% <ø> (-0.70%) ⬇️
utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit 283c761 into main Jun 3, 2024
97 checks passed
@javitonino javitonino deleted the delete_vectors_on_label_change branch June 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants