Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all pre-checks in a single job #2224

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Run all pre-checks in a single job #2224

merged 3 commits into from
Jun 6, 2024

Conversation

javitonino
Copy link
Contributor

Description

  • Move all pre-checks to the New CI pipeline in a single job (less workers taken for linting = more workers available for testing)
  • Does a single lint for nucliadb (not per-component)
  • Switches flake8 to ruff (only for flake checks, formatting is still done with isort+black to minimize reformatting). The reason for this change is that ruff allows specifying a target python version for checks, so we can use a single Python installation (3.12) for checking all versions since 3.9.
  • Removes code-requirements.txt, these are all managed by pdm now.
  • Removes a bunch of ignored flake8 rules and standardizes in a single set (in ruff.toml). Fixes a few instances of rules being broken.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e3f482b Previous: 0d03d9f Ratio
tests/search/unit/search/test_fetch.py::test_highligh_error 2836.842899803532 iter/sec (stddev: 0.000009108893831615426) 2841.0684406726436 iter/sec (stddev: 0.000004954958228416619) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@javitonino javitonino merged commit 842deb9 into main Jun 6, 2024
63 checks passed
@javitonino javitonino deleted the ci_prechecks branch June 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants