Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and improvements #2343

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Small fixes and improvements #2343

merged 6 commits into from
Jul 26, 2024

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Jul 25, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team July 25, 2024 14:02
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (1b0c11c) to head (723192e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2343      +/-   ##
==========================================
- Coverage   86.48%   86.35%   -0.13%     
==========================================
  Files         369      369              
  Lines       22555    22615      +60     
==========================================
+ Hits        19507    19530      +23     
- Misses       3048     3085      +37     
Flag Coverage Δ
nucliadb 72.98% <100.00%> (-0.12%) ⬇️
nucliadb-ingest 29.53% <100.00%> (+0.02%) ⬆️
nucliadb-reader 25.17% <100.00%> (+0.02%) ⬆️
nucliadb-standalone 47.81% <0.00%> (+0.02%) ⬆️
nucliadb-train 46.74% <100.00%> (+0.02%) ⬆️
nucliadb-writer 40.49% <100.00%> (+0.01%) ⬆️
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.33% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.57% <ø> (ø)
nucliadb_utils 82.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare force-pushed the small-fixes-and-improvements branch from 5ba0c99 to 723192e Compare July 26, 2024 10:13
@jotare jotare merged commit 25a84b5 into main Jul 26, 2024
43 checks passed
@jotare jotare deleted the small-fixes-and-improvements branch July 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants