Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGCatalog: Metrics & Fix paging #2347

Merged
merged 2 commits into from
Jul 26, 2024
Merged

PGCatalog: Metrics & Fix paging #2347

merged 2 commits into from
Jul 26, 2024

Conversation

javitonino
Copy link
Contributor

@javitonino javitonino commented Jul 26, 2024

Fix PGCatalog paging: stop using merge_results and work directly with the models. This is also a bit faster, we skip a query per resource (to fetch labels, we get them from the catalog directly).

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (1b0c11c) to head (d78fb16).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
- Coverage   86.48%   86.39%   -0.10%     
==========================================
  Files         369      369              
  Lines       22555    22560       +5     
==========================================
- Hits        19507    19491      -16     
- Misses       3048     3069      +21     
Flag Coverage Δ
nucliadb 72.92% <100.00%> (-0.19%) ⬇️
nucliadb-ingest 29.53% <26.66%> (+0.01%) ⬆️
nucliadb-reader 25.16% <26.66%> (+0.01%) ⬆️
nucliadb-search 37.42% <66.66%> (+0.02%) ⬆️
nucliadb-standalone 47.81% <66.66%> (+0.02%) ⬆️
nucliadb-train 46.74% <66.66%> (+0.02%) ⬆️
nucliadb-writer 40.49% <26.66%> (+0.01%) ⬆️
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.33% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.57% <ø> (ø)
nucliadb_utils 82.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino changed the title Skip merge results PGCatalog: Metrics & Fix paging Jul 26, 2024
@javitonino javitonino merged commit 7637c75 into main Jul 26, 2024
43 checks passed
@javitonino javitonino deleted the pgcatalog_metrics branch July 26, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants