Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not receiving searches and suggestions to kb_usage #2349

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

drf7
Copy link
Contributor

@drf7 drf7 commented Jul 26, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (29e58ec) to head (9d15fc0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2349   +/-   ##
=======================================
  Coverage   86.45%   86.46%           
=======================================
  Files         369      369           
  Lines       22639    22648    +9     
=======================================
+ Hits        19573    19582    +9     
  Misses       3066     3066           
Flag Coverage Δ
nucliadb 73.12% <100.00%> (+0.01%) ⬆️
nucliadb-ingest 29.49% <0.00%> (-0.02%) ⬇️
nucliadb-reader 25.15% <0.00%> (-0.02%) ⬇️
nucliadb-search 37.39% <100.00%> (+0.03%) ⬆️
nucliadb-standalone 47.70% <60.00%> (+<0.01%) ⬆️
nucliadb-train 46.64% <60.00%> (+<0.01%) ⬆️
nucliadb-writer 40.39% <0.00%> (-0.03%) ⬇️
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.33% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.57% <ø> (ø)
nucliadb_utils 82.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drf7 drf7 marked this pull request as ready for review July 26, 2024 15:08
@drf7 drf7 changed the title add back search and suggestion kb_usage fix not receiving searches and suggestions to kb_usage Jul 26, 2024
@drf7 drf7 merged commit fe8db55 into main Jul 26, 2024
43 checks passed
@drf7 drf7 deleted the add-back-search-and-suggestions-kb-usage branch July 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants