Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matryohka check #2366

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix Matryohka check #2366

merged 1 commit into from
Aug 1, 2024

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (0f84ed8) to head (e435c5b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2366   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files         370      370           
  Lines       22665    22665           
=======================================
  Hits        19624    19624           
  Misses       3041     3041           
Flag Coverage Δ
nucliadb 73.47% <ø> (ø)
nucliadb-ingest 29.49% <ø> (ø)
nucliadb-reader 25.17% <ø> (ø)
nucliadb-search 37.35% <ø> (ø)
nucliadb-standalone 47.73% <ø> (ø)
nucliadb-train 46.69% <ø> (ø)
nucliadb-writer 40.47% <ø> (ø)
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.40% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.57% <ø> (ø)
nucliadb_utils 83.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit c9a8419 into main Aug 1, 2024
43 checks passed
@javitonino javitonino deleted the fix_matryohka_check branch August 1, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants