Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header decoding on telemetry #2367

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Aug 1, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested a review from a team August 1, 2024 09:18
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.64%. Comparing base (c9a8419) to head (0ad4879).

Files Patch % Lines
...elemetry/src/nucliadb_telemetry/fastapi/tracing.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   86.59%   86.64%   +0.04%     
==========================================
  Files         370      370              
  Lines       22665    22663       -2     
==========================================
+ Hits        19627    19636       +9     
+ Misses       3038     3027      -11     
Flag Coverage Δ
nucliadb 73.57% <ø> (+0.08%) ⬆️
nucliadb-ingest 29.49% <ø> (ø)
nucliadb-reader 25.17% <ø> (ø)
nucliadb-search 37.35% <ø> (ø)
nucliadb-standalone 47.73% <ø> (ø)
nucliadb-train 46.69% <ø> (ø)
nucliadb-writer 40.47% <ø> (ø)
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.40% <ø> (ø)
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.55% <0.00%> (-0.03%) ⬇️
nucliadb_utils 83.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 3d39a58 into main Aug 1, 2024
43 checks passed
@lferran lferran deleted the safer-utf8-decoding-on-telemetry branch August 1, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants