Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict is compatible with vectorsets #2370

Merged
merged 19 commits into from
Aug 1, 2024

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.57%. Comparing base (95f0d93) to head (15e6955).
Report is 2 commits behind head on main.

Files Patch % Lines
nucliadb/src/nucliadb/search/predict.py 50.00% 3 Missing ⚠️
nucliadb/src/nucliadb/search/search/query.py 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2370      +/-   ##
==========================================
- Coverage   86.58%   86.57%   -0.02%     
==========================================
  Files         370      371       +1     
  Lines       22663    22697      +34     
==========================================
+ Hits        19622    19649      +27     
- Misses       3041     3048       +7     
Flag Coverage Δ
nucliadb 73.42% <81.08%> (-0.05%) ⬇️
nucliadb-ingest 29.46% <8.10%> (-0.03%) ⬇️
nucliadb-reader 25.20% <8.10%> (+0.03%) ⬆️
nucliadb-search 37.45% <83.78%> (+0.10%) ⬆️
nucliadb-standalone 47.71% <32.43%> (-0.03%) ⬇️
nucliadb-train 46.74% <32.43%> (+0.04%) ⬆️
nucliadb-writer 40.48% <8.10%> (+<0.01%) ⬆️
nucliadb_dataset 60.09% <ø> (ø)
nucliadb_models 85.43% <100.00%> (+0.03%) ⬆️
nucliadb_sdk 77.48% <ø> (ø)
nucliadb_sidecar 94.23% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 83.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran self-requested a review August 1, 2024 15:16
@javitonino javitonino merged commit 16c19f1 into main Aug 1, 2024
51 checks passed
@javitonino javitonino deleted the predict-is-compatible-with-vectorsets branch August 1, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants